Skip to content

Correct gRPC development ranges for GHSA-2v4p-qf9q-27wj - #9608

Open
raphael wants to merge 1 commit into
github:raphael/advisory-improvement-9608from
raphael:codex/grpc-advisory-ranges-20260919
Open

raphael wants to merge 1 commit into
github:raphael/advisory-improvement-9608from
raphael:codex/grpc-advisory-ranges-20260919

Conversation

@raphael

@raphael raphael commented Sep 19, 2026

Copy link
Copy Markdown

The current affected-version interval includes released gRPC-Go v1.84.0 even though that release contains the fix for GHSA-2v4p-qf9q-27wj. Split the development-version interval by release branch so fixed v1.84.0 is excluded while unpatched 1.84 and 1.85 development versions remain affected.

The current interval starts at 1.84.0-dev and ends at 1.85.0-dev.0.20260825072537-93e31b48545e. Version ordering places stable 1.84.0 inside that interval. However, backport PR #9370 cherry-picked the original fix into v1.84.x as d5a41119e0e3. That commit is an ancestor of the v1.84.0 release, three commits before its exact tag target e84aa5ab15d1d2b29d54f838312ad490cb7551a8.

The corrected development ranges are:

Introduced, inclusive Fixed, exclusive
1.84.0-dev 1.84.0-dev.0.20260825144003-d5a41119e0e3
1.85.0-dev 1.85.0-dev.0.20260825072537-93e31b48545e

The Go module query for the exact backport commit returns the first fixed version above. The second range retains the existing main-branch fix at 93e31b48545e; the v1.85.0-dev tag precedes that fix and remains affected. The existing ranges fixed in 1.82.2 and 1.83.2 are unchanged.

The final v1.84.0 source still contains both checks: the HTTP/2 transport rejects a request lacking both host and authority before dispatch, and xDS routing rejects an empty authority slice before indexing it. The corresponding transport, routing and end-to-end regression tests are present in that tagged source. This is source and ancestry verification, not a claim that upstream tests were rerun.

Only this advisory changes: the two development ranges, the patch explanation, and public backport/release references. Severity, affected package, existing stable ranges and other metadata remain unchanged. The original JSON formatting, including its missing final newline, is preserved. JSON parsing and applying the patch against the captured advisory both passed. No application code, dependency pin, security-check exemption or migration is involved; advisory consumers can use the corrected ranges after GitHub curates and publishes the update.

Copilot AI balanced review requested due to automatic review settings September 19, 2026 05:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions
github-actions Bot changed the base branch from main to raphael/advisory-improvement-9608 September 19, 2026 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants