[GHSA-xfqm-j7pc-xrfc] messageformat has a prototype pollution vulnerability#8790
Open
yusuke-koyoshi wants to merge 1 commit into
Open
Conversation
github-actions
Bot
changed the base branch from
main
to
yusuke-koyoshi/advisory-improvement-8790
July 23, 2026 13:33
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the prototype-pollution advisory’s affected versions, scoring, and description.
Changes:
- Extends affected
messageformatversions through3.0.0-beta.0. - Adds
@messageformat/runtimeversions before3.0.2. - Updates CVSS v4 scoring and severity.
Comments suppressed due to low confidence (3)
advisories/github-reviewed/2025/09/GHSA-xfqm-j7pc-xrfc/GHSA-xfqm-j7pc-xrfc.json:54
- The affected list still stops after
@messageformat/runtime, although the PR description says this advisory must also cover@messageformat/icu-messageformat-1(< 0.12.0),@messageformat/fluent(< 0.14.0), and the legacymessageformat-runtimepackage. Omitting those entries leaves users of three stated affected products undetected; add their separateaffected[]ranges before closing this array.
]
advisories/github-reviewed/2025/09/GHSA-xfqm-j7pc-xrfc/GHSA-xfqm-j7pc-xrfc.json:10
- This changed description misidentifies the affected
messageformatreleases as an implementation of Unicode MessageFormat 2. The upstream v2.3.0 README documents ICU MessageFormat instead, so the advisory currently names the wrong specification.
"details": "The messageformat package, an implementation of the Unicode MessageFormat 2 specification for JavaScript, is vulnerable to prototype pollution due to improper handling of message key paths. The flaw arises when processing nested message keys containing special characters (e.g., __proto__ ), which can lead to unintended modification of the JavaScript Object prototype. This vulnerability may allow a remote attacker to inject properties into the global object prototype via specially crafted message input, potentially causing denial of service or other undefined behaviors in applications using the affected component.",
advisories/github-reviewed/2025/09/GHSA-xfqm-j7pc-xrfc/GHSA-xfqm-j7pc-xrfc.json:54
- The PR description explicitly says to add commit
82cd10b4as the actual fix reference, but the unchangedreferencesarray still contains only the NVD advisory, issue #452, and package repository. Add the full commit URL (and preferably PR #464) so downstream users can trace the fix claimed by this update.
]
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "schema_version": "1.4.0", | ||
| "id": "GHSA-xfqm-j7pc-xrfc", | ||
| "modified": "2025-09-25T16:46:42Z", | ||
| "modified": "2025-09-25T16:46:43Z", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
Comments
The current advisory's version metadata does not match the actual fix history in the repository:
Affected range is off-by-one. The advisory lists
< 2.3.0, butmessageformat@2.3.0itself contains the vulnerableMessages.addMessages()code path (identical to prior 2.x releases). The correct upper bound is< 3.0.0-beta.0."Patched: 3.0.0-beta.0" is misleading. In
3.0.0-beta.0the vulnerableMessagesclass was relocated to a separate package (@messageformat/runtime), not fixed. Themessageformatpackage is therefore no longer affected from 3.0.0-beta.0 onward, but the vulnerability continued to exist in@messageformat/runtime < 3.0.2.Missing affected packages. The same vulnerable code is / was shipped in
@messageformat/runtime(fixed in3.0.2),@messageformat/icu-messageformat-1(fixed in0.12.0),@messageformat/fluent(fixed in0.14.0), and the unmaintained legacymessageformat-runtime. These should be added as separateaffected[]entries.Actual fix reference. The real fix is commit
82cd10b4(PR #464, 2025-10-30), which introduces_withNullPrototype()and replaces{}withObject.create(null)for keypath intermediates. Adding this as a reference would help downstream tooling.2.x is wontfix. Per maintainer comment on issue #452, the 2.x line will not be patched (deprecated since 2021). Users must upgrade to
messageformat@4.0.0.