Skip to content

Babel improvements #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mtscout6 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Babel improvements #366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96daeba
refactor(build): Add babel-plugin-add-module-exports to allow ECMA201…
mtscout6 Jul 14, 2016
9bfc03e
refactor(build): Use babel-runtime instead of es6-promise polyfill
mtscout6 Jul 14, 2016
eb865ee
chore: Fix linting error
mtscout6 Nov 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gulpfile.babel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ const externalConfig = {
external: [
'axios',
'js-base64',
'es6-promise',
'babel-runtime',
'debug',
'utf8'
],
Expand Down
3 changes: 2 additions & 1 deletion lib/Repository.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,8 @@ class Repository extends Requestable {
* @return {Promise} - the promise for the http request
*/
updatePullRequst(number, options, cb) {
log('Deprecated: This method contains a typo and it has been deprecated. It will be removed in next major version. Use updatePullRequest() instead.');
log('Deprecated: This method contains a typo and it has been deprecated. It will be removed in next major ' +
'version. Use updatePullRequest() instead.');

return this.updatePullRequest(number, options, cb);
}
Expand Down
5 changes: 0 additions & 5 deletions lib/Requestable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,9 @@
import axios from 'axios';
import debug from 'debug';
import {Base64} from 'js-base64';
import {polyfill} from 'es6-promise';

const log = debug('github:request');

if (typeof Promise === 'undefined') {
polyfill();
}

/**
* The error structure returned when a network call fails
*/
Expand Down
15 changes: 6 additions & 9 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,9 @@
"es2015"
],
"plugins": [
[
"transform-es2015-modules-umd",
{
"globals": {
"es6-promise": "Promise"
}
}
]
"add-module-exports",
"transform-runtime",
"transform-es2015-modules-umd"
],
"env": {
"development": {
Expand All @@ -46,14 +41,16 @@
],
"dependencies": {
"axios": "^0.10.0",
"babel-runtime": "^6.9.2",
"debug": "^2.2.0",
"es6-promise": "^3.0.2",
"js-base64": "^2.1.9",
"utf8": "^2.1.1"
},
"devDependencies": {
"babel-core": "^6.7.7",
"babel-plugin-add-module-exports": "^0.2.1",
"babel-plugin-transform-es2015-modules-umd": "^6.5.0",
"babel-plugin-transform-runtime": "^6.9.0",
"babel-preset-es2015": "^6.5.0",
"babel-register": "^6.7.2",
"babelify": "^7.3.0",
Expand Down