feature(watching): Add support for ignoring or subscribing to repos#360
feature(watching): Add support for ignoring or subscribing to repos#360mtscout6 wants to merge 1 commit intogithub-tools:masterfrom
Conversation
|
ping |
| * Watching a Repository registers the user to receive notifications on new discussions, as well as events in the user's | ||
| * activity feed. | ||
| */ | ||
| export default class Watching extends Requestable { |
There was a problem hiding this comment.
At the moment we use module.exports for exporting classes. I'm not sure about the reason as this was made by @clayreimann but I think it's because we aren't using the babel plugin to revert the export of defaults to the behavior of Babel 5.
There was a problem hiding this comment.
I didn't know there was such a plugin. I forget the exact reason that we're using module.exports but it boiled down to nothing works if you use the export default syntax.
If there's a plugin that fixes things while allowing us to use the new syntax then I'm all for it.
There was a problem hiding this comment.
There was a problem hiding this comment.
I've used that plugin before as well. I'll get it wired up.
There was a problem hiding this comment.
I suggest to do it in a separate PR.
There was a problem hiding this comment.
The commit is already in, it was a two line change and doesn't require me to change this. I can do that if you like though.
There was a problem hiding this comment.
If I do a separate PR for this, then I'll tackle the babel-runtime issue as well. I'll crank that out real quick.
There was a problem hiding this comment.
Alright it is in PR #366 We should hold off on this PR until that one is done because of this line.
3 participants
See: https://developer.github.com/v3/activity/watching/