Skip to content

fix(runners): guard SEGMENT against set -u in start-runner.sh #5233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jensenbox wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

fix(runners): guard SEGMENT against set -u in start-runner.sh #5233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/runners/templates/start-runner.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ cleanup() {

if [ "$exit_code" -ne 0 ]; then
echo "ERROR: runner-start-failed with exit code $exit_code occurred on $error_location"
create_xray_error_segment "$SEGMENT" "runner-start-failed with exit code $exit_code occurred on $error_location - $error_lineno"
create_xray_error_segment "$${SEGMENT:-}" "runner-start-failed with exit code $exit_code occurred on $error_location - $error_lineno"
fi
# allows to flush the cloud watch logs and traces
sleep 10
Expand Down Expand Up @@ -260,7 +260,7 @@ if [[ "$enable_jit_config" == "false" || $agent_mode != "ephemeral" ]]; then
tag_instance_with_runner_id
fi

create_xray_success_segment "$SEGMENT"
create_xray_success_segment "$${SEGMENT:-}"
if [[ $agent_mode = "ephemeral" ]]; then
echo "Starting the runner in ephemeral mode"

Expand Down
Loading