Add canonical settings and terms commands - #268
Merged
Conversation
skvark
force-pushed
the
agent/add-settings-commands
branch
from
August 11, 2026 07:36
311b5e8 to
79f5f24
Compare
skvark
marked this pull request as ready for review
August 11, 2026 10:55
Add the canonical account settings UX, terms acceptance and token refresh flows, and shared REST/GraphQL remediation handling. Preserve structured CLI and MCP errors across OAuth and opaque API-token authentication.
Remove the development account origin from public examples and allow newer account APIs to add settings fields without breaking older CLI versions.
skvark
force-pushed
the
agent/add-settings-commands
branch
from
August 11, 2026 11:33
64e7b78 to
3379a39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
githits settingsplus typedshow,get,set <key> <values...>, andclear <key>commandsmarketing-emails disabledto canonical account API fieldsclearsettings terms/settings terms accept, accepting either OAuth JWTs or opaqueghi-*credentialsTERMS_ACCEPTANCE_REQUIREDresponses once in shared transport code, refresh/retry OAuth once, and return one shared CLI/MCP remediation with separate legal and environment-specific browser-acceptance URLsNo settings mutation was added as an MCP tool or public
@githits/mcpAPI. The release process can decide the later MCP package version bump for the new agent-facing error envelope.Settings UX
JSON batch input is intentionally deferred until an atomic multi-setting workflow is required.
Validation
bun test(2,626 passed)bun run typecheckbun run buildgit diff --checkDev validation
Validated against the deployed Dev accounts and GitHits API services with a real user:
ghi-*--jsonworks before or after nested subcommandsTERMS_ACCEPTANCE_REQUIREDwith the legal and Dev acceptance URLsghi-*acceptance succeeds without token refresh and the immediate retry succeedsThe user's current terms acceptance was restored and verified after the test. PkgSeer gate validation remains separate until its PR is deployed to Dev. This PR does not deploy production.