CIHelper: move the responsibility to push from handleOpenPRs() to handlePR()

We already push the notes ref when updating the PR metadata (i.e. the
object attached to the blob whose contents are the PR URL), therefore it
makes only sense to combine that with any update to the
GitGitGadgetOptions (i.e. the object attached to the empty object).

This simplifies the logic (and the separation of concerns) quite a bit.

Suggested-by: Chris. Webster <chris@webstech.net>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Author: dscho

lib/ci-helper.ts

@@ -251,34 +251,23 @@ export class CIHelper {
     /**
      * Process all open PRs.
      *
-     * @returns true if `refs/notes/gitgitgadget` was updated (and needs to
-     * be pushed)
+     * @returns true if `refs/notes/gitgitgadget` was updated
      */
     public async handleOpenPRs(): Promise<boolean> {
         const options = await this.getGitGitGadgetOptions();
         if (!options.openPRs) {
             return false;
         }
         let result = false;
-        let optionsUpdated = false;
         for (const pullRequestURL in options.openPRs) {
             if (!Object.prototype.hasOwnProperty.call(options.openPRs, pullRequestURL)) {
                 continue;
             }
             console.log(`Handling ${pullRequestURL}`);
-            const [notesUpdated, optionsUpdated2] = await this.handlePR(pullRequestURL, options);
-            if (notesUpdated) {
+            const [notesUpdated, optionsUpdated] = await this.handlePR(pullRequestURL, options);
+            if (notesUpdated || optionsUpdated) {
                 result = true;
             }
-            if (optionsUpdated2) {
-                optionsUpdated = true;
-            }
-        }
-
-        if (optionsUpdated) {
-            await this.notes.set("", options, true);
-            await this.notes.push(this.urlRepo);
-            result = true;
         }
 
         return result;
@@ -416,6 +405,9 @@ export class CIHelper {
 
         if (optionsUpdated) {
             await this.notes.set("", options, true);
+        }
+
+        if (notesUpdated || optionsUpdated) {
             await this.notes.push(this.urlRepo);
         }