misc-helper handle-pr: remove redundant notes.set() call

dscho · dscho · commit 57beda41a281 · 2025-08-12T10:58:50.000+02:00
The `CIHelper.handlePR()` method already took care of updating the
notes, no need to do it again.

Signed-off-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt;
diff --git a/script/misc-helper.ts b/script/misc-helper.ts
@@ -365,11 +365,7 @@ const commandOptions = commander.opts<ICommanderOptions>();
                 }
 
                 const [notesUpdated2, optionsUpdated2] = await ci.handlePR(pullRequestURL, options);
-                if (notesUpdated2) {
-                    notesUpdated = true;
-                }
-                if (optionsUpdated || optionsUpdated2) {
-                    await ci.notes.set("", options, true);
+                if (notesUpdated2 || optionsUpdated || optionsUpdated2) {
                     notesUpdated = true;
                 }
                 console.log(`Notes were ${notesUpdated ? "" : "not "}updated`);

Original file line number	Diff line number	Diff line change
`@@ -365,11 +365,7 @@ const commandOptions = commander.opts<ICommanderOptions>();`
`365`	`365`	`}`
`366`	`366`
`367`	`367`	`const [notesUpdated2, optionsUpdated2] = await ci.handlePR(pullRequestURL, options);`
`368`		`- if (notesUpdated2) {`
`369`		`- notesUpdated = true;`
`370`		`- }`
`371`		`- if (optionsUpdated \|\| optionsUpdated2) {`
`372`		`- await ci.notes.set("", options, true);`
	`368`	`+ if (notesUpdated2 \|\| optionsUpdated \|\| optionsUpdated2) {`
`373`	`369`	`notesUpdated = true;`
`374`	`370`	`}`
`375`	`371`	console.log(`Notes were ${notesUpdated ? "" : "not "}updated`);