feat: --note on claims, carried wherever the lock is named (0.6.0) - #30
Merged
Merged
Conversation
claim --note <text>, with --note, and note: in a batch record store one line saying why the lock is held. It rides on the claim line, show, list, check on a held or expired path, and the refusal another claimant gets, which can now read "held by alice: building the release bundle" rather than just "held by alice". extend and a child admission keep it through the record rewrite. A note is one line; empty means none, and the key is absent from every line when there is none. Optional in the schema. Version 0.6.0. Closes #8
|
Warning Review limit reachedNext included review available in 10 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (16)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roadmap item 4 (#8).
claim --note <text>,with --note <text>, andnote:in a batch record store one line saying why the lock is held. It is carried on every line that names the lock: the claim line,show,list,checkon a held or expired path, and the refusal another claimant gets, which can now read "held by alice: building the release bundle" rather than just "held by alice".extendand a child admission (the parent's family bump rewrites its record) keep it.note:afteracquisition:, beforepaths:) and one optionalnoteproperty in the schema onclaim_line,list_line,check_line(held and expired only; the free branch forbids it) and the held variant ofrefusal_line. No new refs.--noteis no note. When there is no note the key is absent from every line, which the tests assert.describeexposesD_NOTE_JSON, an empty string or,"note":"…", spliced after the holder wherever a lock is rendered, so the render paths stay fork-free.Tests written first: fifteen RED, then 392 green, lint clean. Version 0.6.0.
Closes #8