Acquisition id survives renewal; with releases by it (v0.3.1)

[flyingrobots]

Closes the second half of the review's MUST 4: claim_id distinct from record_oid. Reproduced first (extend inside with left the lock held), fixed, plus a second forced interleaving and honest timing numbers. Merging tags v0.3.1.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: d75ffaeb-2e23-4779-8c16-8dcbdc34fe8b

📥 Commits

Reviewing files that changed from the base of the PR and between e3706f2 and 00d0738.

📒 Files selected for processing (5)

• CHANGELOG.md
• README.md
• bin/git-locks
• schema/git-locks.schema.json
• test/test.sh

---

📝 Summary

Summary by CodeRabbit

• New Features

  • Added stable acquisition IDs that persist across renewals and parent/child lock updates.
  • Added --acquisition support for releasing locks and semaphore acquisitions across renewals.
  • Updated with cleanup to release the acquisition it created.
  • Semaphore reacquisition preserves its ID while active and creates a new one after expiry.
  • Lock and semaphore output now includes acquisition IDs.

• Documentation

  • Updated command help, JSON schema, README, and changelog to document acquisition identity and performance measurements.

Walkthrough

The lock system adds stable acquisition IDs separate from mutable record IDs. Claims, renewals, parent rewrites, releases, with, semaphores, schemas, documentation, and tests now use or describe the new identity.

Changes

Acquisition identity lifecycle

Layer / File(s)	Summary
Lock identity and claim contract bin/git-locks, schema/git-locks.schema.json	Claims mint acquisition IDs and include them with record IDs in lock records and output.
Renewal-safe release and cleanup bin/git-locks, test/test.sh, schema/git-locks.schema.json, CHANGELOG.md	Release accepts acquisition selectors. Renewals and parent rewrites preserve acquisition IDs. with cleanup and interleaved release tests use the stable identity.
Semaphore acquisition identity bin/git-locks, schema/git-locks.schema.json	Live semaphore reacquisition preserves its acquisition ID. New or expired slots receive new IDs. Semaphore release accepts acquisition selectors.
Release documentation and measurements README.md	Documentation distinguishes job, acquisition, and record IDs. It also records parent timing behavior and measurements for 500 locks.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Bug fix · Severity of issue fixed: Medium

Poem

A rabbit claims a lasting name

Renewed records still play the game
Release finds the thread anew
Semaphores keep their promise too
The lock hops free when work is through

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{A rabbit reads each line,
The patch grows clear beneath the moon,
Small changes hop in place,
Tests guard the garden path,
Reviews bloom before the dawn.}

_{Comment @coderabbitai help to get the list of available commands.}