fix: centralize pass-through response relaying - #380
Open
abhinavgautam01 wants to merge 1 commit into
Open
abhinavgautam01 wants to merge 1 commit into
abhinavgautam01 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #326
Summary
Centralize pass-through response handling so connection-scoped headers are not forwarded, upstream trailers are preserved and incomplete downloads are not presented as successfully completed responses.
Changes
ProxyUpstream,ProxyFile, streaming metadata and protocol-specific pass-through paths.Connection.http.ErrAbortHandler, closing HTTP/1 connections or resetting HTTP/2 streams.Vary: Acceptand Swift URL rewriting.Scope and limitations
Validation
Added regression coverage for route-level header stripping, declared and late trailers, truncated chunked responses, HEAD and bodiless statuses, invalid trailers, copy-error logging and upstream body cleanup.
Real-client tests verify late trailers and interrupted responses through the production middleware over HTTP/1.1 and HTTP/2.
Local checks passed:
git diff --checkgo tool golangci-lint run ./...— 0 issuesgo test -race ./...go vet ./...go build ./...go mod tidy -diffCross-platform validation is left to CI.