Conversation
Contributor
andrew
commented
Mar 18, 2026
andrew
commented
- Refactor buildSingleCommand to reduce cognitive complexity (47 -> under 30) by extracting helper methods
- Convert if-else chains to switch statements in translator.go
- Extract magic numbers into named constants in validate.go, extractor.go, and example files
- Fix unused parameters in example code
- Add nolint:ireturn directives for intentional interface returns in detector API
Refactor buildSingleCommand to reduce cognitive complexity by extracting helpers. Convert if-else chains to switch statements. Extract magic numbers into named constants. Fix unused parameters in examples. Add nolint directives for intentional interface returns in detector API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.