Merged
Conversation
Extract helpers to reduce cognitive/cyclomatic complexity and eliminate duplicate code in both production and test files. Replace magic numbers with named constants, fix else-if style issue, and convert POSIX class matching from switch to map lookup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves all 17 issues reported by golangci-lint with gocritic, gocognit, gocyclo, dupl, and mnd linters enabled.
buildSegments,validateSegmentBrackets,appendTrailingDoubleStarfromcompilePatternto reduce cognitive complexityvalidateBracketAtfromvalidateBracketsmatchBracketElementandreadBracketCharfrommatchBracketmatchPosixClassfrom switch to map lookup to reduce cyclomatic complexityelse { if }toelse ifin wildmatch.goposixClassOffset,extraStarSegments)initGitRepo,createCheckPaths,compareWithGit,setupMatcherRoot,setupScopedMatcher) to eliminate duplicate code across git-check-ignore test functions