Repository navigation
Parse Config once when first used concurrently - #16
Merged
Merged
Conversation
parse set parsed before filling the durations, so a concurrent first call could see cooldown as off or read the maps while they were written. It now runs through a sync.Once.
andrew
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config.parsesetparsedbefore it filled the durations, so a goroutine making a concurrent first call could see cooldown as off, or read the maps while another goroutine wrote them.The parsing now runs through a
sync.Oncefield, as suggested in the issue. The public API is unchanged.Configcan no longer be copied after use withoutgo vetflagging it, soTestConfigEnablednow holds*Config. The proxy only passes*cooldown.Config.TestConfigConcurrentFirstUsemakes eight concurrent first calls toForon a freshConfig. Without the fix the race detector reports the race, and even without-racesome calls return the 3d default instead of the 7d npm duration.Fixes #15.