Fix lint issues from golangci-lint quality checks#4
Merged
Conversation
Contributor
andrew
commented
Mar 18, 2026
andrew
commented
- Return concrete types from openTar, openZip, openGem to satisfy ireturn (nolint on the two public factory functions where returning the interface is by design)
- Extract compareFile helper from Compare to reduce cognitive complexity below threshold
- Convert if-else chain to switch statement in file comparison logic
- Replace magic number 8192 with binaryCheckSize constant
- Add TypeModified/TypeAdded/TypeDeleted constants for repeated diff type strings
Return concrete types from internal factory functions to satisfy ireturn, extract compareFile helper to reduce cognitive complexity, convert if-else chain to switch, and replace magic numbers and repeated strings with named constants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.