Implement exercise T4L2/tags-add #85

MousseDm · 2025-10-27T10:31:48Z

Exercise Review

Exercise Discussion

#61

Checklist

If you require a new remote repository on the Git-Mastery organization, have you created a request for it?
Have you written unit tests using repo-smith to validate the exercise grading scheme?
Have you tested the download script using test-download.sh?
Have you verified that this exercise does not already exist or is not currently in review?
Did you introduce a new grading mechanism that should belong to git-autograder?
Did you introduce a new dependency that should belong to app?

damithc · 2025-10-28T06:43:24Z

@MousseDm Closing this as you already have one hp-* PR

VikramGoyal23 · 2025-10-28T10:27:06Z

@damithc This seems to be their exercise implementation, not their hands-on implementation.

@MousseDm You have accidentally left in your implementation of hp-ignore-file in your tags-add branch, in the form of the commit 3f000ca.

damithc · 2025-10-28T10:41:02Z

@damithc This seems to be their exercise implementation, not their hands-on implementation.

Ah, right. Thanks @VikramGoyal23
reopening.

woojiahao

Left several comments. The main points are:

Create unit tests for the autograding to ensure that it works. If there are commands that are insufficient from repo-smith, ping me and I will add them
All comments should be a constant for ease of unit testing
All comments should avoid using the ` character. Use " instead

woojiahao · 2025-11-20T08:56:54Z

tags_add/download.py

+__resources__ = []
+


Suggested change

__resources__ = []

woojiahao · 2025-11-20T08:57:31Z

tags_add/README.md

+1. Add a **lightweight** tag `first-pilot` to the **first commit**.
+2. Add an **annotated** tag `v1.0` to the commit that updates March duty roster, with message `first full duty roster`.


These should go under Task

woojiahao · 2025-11-20T08:57:45Z

tags_add/README.md

+```bash
+# first commit
+git rev-list --max-parents=0 HEAD
+
+# add lightweight tag
+git tag first-pilot <FIRST_COMMIT_SHA>
+
+# find the commit for "Update roster for March"
+git log --oneline | grep -i "Update roster for March"
+
+# add annotated tag with message
+git tag -a v1.0 -m "first full duty roster" <MARCH_COMMIT_SHA>


Please use the Github collapsible sections.

woojiahao · 2025-11-20T08:58:31Z

tags_add/README.md

+```bash
+# first commit
+git rev-list --max-parents=0 HEAD
+
+# add lightweight tag
+git tag first-pilot <FIRST_COMMIT_SHA>
+
+# find the commit for "Update roster for March"
+git log --oneline | grep -i "Update roster for March"
+
+# add annotated tag with message
+git tag -a v1.0 -m "first full duty roster" <MARCH_COMMIT_SHA>


There's a missing closing tag for the code block. Add ``` to the end

woojiahao · 2025-11-20T08:59:33Z

tags_add/tests/test_verify.py

We will need unit tests to ensure that the autograding works. Please refer to the other exercises to understand how autograding unit testing works.

woojiahao · 2025-11-20T09:21:27Z

tags_add/verify.py

+        comments.append(f"Missing annotated tag `{SECOND_TAG}`.")
+    else:
+        if not isinstance(getattr(t_v1, "tag", None), TagObject):
+            comments.append(f"`{SECOND_TAG}` must be an annotated tag.")


This should be a constant

woojiahao · 2025-11-20T09:21:33Z

tags_add/verify.py

+        else:
+            msg = (t_v1.tag.message or "").strip()
+            if msg != SECOND_TAG_MSG:
+                comments.append(f"`{SECOND_TAG}` message must be exactly `{SECOND_TAG_MSG}`.")


This should be a constant

woojiahao · 2025-11-20T09:21:38Z

tags_add/verify.py

+            if msg != SECOND_TAG_MSG:
+                comments.append(f"`{SECOND_TAG}` message must be exactly `{SECOND_TAG_MSG}`.")
+        if not march_commit:
+            comments.append(f"Could not find the commit containing '{MARCH_MSG_FRAGMENT}'.")


This should be a constant

woojiahao · 2025-11-20T09:21:44Z

tags_add/verify.py

+                comments.append(
+                    f"`{SECOND_TAG}` should point to March commit {march_commit.hexsha[:7]}, "
+                    f"but points to {t_v1.commit.hexsha[:7]} instead."
+                )


This should be a constant

woojiahao · 2025-11-20T09:22:22Z

tags_add/verify.py

+    status = GitAutograderStatus.SUCCESSFUL if not comments else GitAutograderStatus.FAILED
+    return exercise.to_output(comments, status)


We would like to provide positive feedback if they do succeed! So I would opt to provide a positive note for students like "Great work using git tag to annotate various commits in the repository!"

damithc closed this Oct 28, 2025

damithc reopened this Oct 28, 2025

damithc linked an issue Oct 28, 2025 that may be closed by this pull request

[Exercise Discussion] T4L2/tags-add #61

Open

1 task

MousseDm added 2 commits October 31, 2025 02:36

Exercise(tags-add): add download and verify (tag v1.0.0)

71a164a

Correct exercise configuration and verify logic

ab9a8b2

MousseDm force-pushed the tags-add branch from 9453ae3 to ab9a8b2 Compare October 30, 2025 19:14

woojiahao added the exercise review Review a proposed exercise label Nov 10, 2025

woojiahao requested changes Nov 20, 2025

View reviewed changes

woojiahao added the discussing label Nov 20, 2025

		1. Add a lightweight tag `first-pilot` to the first commit.
		2. Add an annotated tag `v1.0` to the commit that updates March duty roster, with message `first full duty roster`.

		status = GitAutograderStatus.SUCCESSFUL if not comments else GitAutograderStatus.FAILED
		return exercise.to_output(comments, status)

Implement exercise T4L2/tags-add #85

Are you sure you want to change the base?

Implement exercise T4L2/tags-add #85

Uh oh!

Conversation

MousseDm commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Exercise Review

Exercise Discussion

Checklist

Uh oh!

damithc commented Oct 28, 2025

Uh oh!

VikramGoyal23 commented Oct 28, 2025

Uh oh!

damithc commented Oct 28, 2025

Uh oh!

woojiahao left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MousseDm commented Oct 27, 2025 •

edited

Loading