Skip to content

Conversation

@kea-S
Copy link

@kea-S kea-S commented Nov 16, 2025

Exercise Review

merge-undo

Exercise Discussion

#67

Checklist

  • If you require a new remote repository on the Git-Mastery organization, have you created a request for it?
  • Have you written unit tests using repo-smith to validate the exercise grading scheme?
  • Have you tested the download script using test-download.sh?
  • Have you verified that this exercise does not already exist or is not currently in review?
  • Did you introduce a new grading mechanism that should belong to git-autograder?
  • Did you introduce a new dependency that should belong to app?

@woojiahao woojiahao self-assigned this Nov 20, 2025
@woojiahao woojiahao added exercise review Review a proposed exercise discussing labels Nov 20, 2025
@woojiahao woojiahao linked an issue Nov 20, 2025 that may be closed by this pull request
1 task
Copy link
Member

@woojiahao woojiahao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The autograding and unit testing LGTM! Just comments on the download itself. Thank you!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not need to be a res/ file! The app automatically pulls the README.md



def setup(verbose: bool = False):
create_start_tag(verbose)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is necessary

create_start_tag(verbose)

# main branch
checkout("main", False, verbose)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
checkout("main", False, verbose)

Not necessary. The default branch should always be main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

discussing exercise review Review a proposed exercise

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Exercise Discussion] T6L2/merge-undo

2 participants