Implement hands on hp-reset-commits #114
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woojiahao
requested changes
Nov 10, 2025
Member
woojiahao
left a comment
woojiahao
left a comment
There was a problem hiding this comment.
Implementation LGTM, but left nits about convention!
hands_on/reset_commits.py
Outdated
| """ | ||
| another bad shape | ||
| """ | ||
| ) No newline at end of file |
hands_on/reset_commits.py
Outdated
Comment on lines
111
to
113
| """ | ||
| another bad shape | ||
| """ |
Member
There was a problem hiding this comment.
Believe you can make this a single line and it'll still append correctly!
hands_on/reset_commits.py
Outdated
Comment on lines
103
to
105
| """ | ||
| another bad colour | ||
| """ |
hands_on/reset_commits.py
Outdated
Comment on lines
94
to
96
| """ | ||
| bad line | ||
| """ |
hands_on/reset_commits.py
Outdated
Comment on lines
85
to
87
| """ | ||
| bad fruit | ||
| """ |
hands_on/reset_commits.py
Outdated
Comment on lines
76
to
78
| """ | ||
| bad shape | ||
| """ |
hands_on/reset_commits.py
Outdated
Comment on lines
67
to
69
| """ | ||
| bad colour | ||
| """ |
hands_on/reset_commits.py
Outdated
Comment on lines
44
to
46
| """ | ||
| a file for shapes | ||
| """ |
hands_on/reset_commits.py
Outdated
Comment on lines
38
to
40
| """ | ||
| a file for colours | ||
| """ |
Member
|
@desmondwong1215 bumping on this to address the comments! Once addressed, the changes should be good to merge |
Author
|
@woojiahao Hi, I have fixed this formatting issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exercise Review
Exercise Discussion
#107
Checklist
Git-Masteryorganization, have you created a request for it?repo-smithto validate the exercise grading scheme?test-download.sh?git-autograder?app?