Implement exercise T4L1/view-commits #102
Conversation
woojiahao
left a comment
woojiahao
left a comment
There was a problem hiding this comment.
Thank you @SAN-MUYUN for helping to work on this exercise! I've added some comments!
| from exercise_utils.gitmastery import create_start_tag | ||
|
|
||
| def setup(verbose: bool = False): | ||
| create_start_tag(verbose) |
There was a problem hiding this comment.
I don't think we need this. We can just leave this function as ...
| .add_validation(QUESTION_TWO, NotEmptyRule()) | ||
| .add_validation(QUESTION_TWO, HasExactValueRule("Bruce", is_case_sensitive=True)) | ||
| .add_validation(QUESTION_THREE, NotEmptyRule()) | ||
| .add_validation(QUESTION_THREE, HasExactListRule(["Betsy", "Beth", "Daisy"], is_case_sensitive=True)) | ||
| .add_validation(QUESTION_THREE, ContainsListRule(["Betsy", "Beth", "Daisy"], subset=True, is_case_sensitive=True)) | ||
| .add_validation(QUESTION_FOUR, NotEmptyRule()) | ||
| .add_validation(QUESTION_FOUR, HasExactListRule(["Charlie"], is_case_sensitive=True)) | ||
| .add_validation(QUESTION_FOUR, ContainsListRule(["Charlie"], subset=True, is_case_sensitive=True)) |
There was a problem hiding this comment.
The add_validation function takes in a variadic list of arguments, so you can pass all of the rules for a given question within the same call to add_validation!
There was a problem hiding this comment.
Thank you for writing such comprehensive test specs for the answers.txt! But it's completely okay to keep the spec as the base file! When you set mock_answers, it immediately loads in the answers.txt with the answers you give it! So it doesn't read off of the unit tested file.
|
Thanks so much for the feedback! I will make the necessary changes hopefully by next week. |
2 participants
Exercise Review
Exercise Discussion
#60
Checklist
Git-Masteryorganization, have you created a request for it?repo-smithto validate the exercise grading scheme?test-download.sh?git-autograder?app?