Implement exercise T6L2/ff-undo #101
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
woojiahao
requested changes
Nov 20, 2025
Member
woojiahao
left a comment
woojiahao
left a comment
There was a problem hiding this comment.
Left some comments, the structure for autograding makes sense, but could be improved
ff_undo/verify.py
Outdated
| has_birdperson = any("Add Birdperson" in msg for msg in commit_messages_in_others) | ||
| has_cyborg = any("Add Cyborg to birdperson.txt" in msg for msg in commit_messages_in_others) | ||
| has_tammy = any("Add Tammy" in msg for msg in commit_messages_in_others) | ||
| if len(commit_messages_in_others) != 6 or not (has_birdperson and has_cyborg and has_tammy): |
Member
There was a problem hiding this comment.
A little OOTL, but why is this check for 6, not 3?
Contributor
Author
There was a problem hiding this comment.
When retrieving commits from the others branch, it also includes the commits from main that existed before the branch was created. Therefore, the total number of commits is 5 instead of 3 (since I deleted the first tag, it now counts as 5).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exercise Review
Exercise Discussion
#89
Checklist
Git-Masteryorganization, have you created a request for it?repo-smithto validate the exercise grading scheme?test-download.sh?git-autograder?app?