Really accommodate for pc-msys -> pc-cygwin change
#629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` change The MSYS2 project switched its triplet from `x86_64-pc-msys` to `x86_64-pc-cygwin`. We need to accommodate for that. In 804d581 (git-sdk.sh: accommodate for the recent `pc-msys` -> `pc-cygwin` change, 2025-06-22), I already tried to accommodate for that, but failed to realize that the `chost` triplet is used at two separate levels of the build directory's absolute path, not only one. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
mjcheetham
approved these changes
Jul 9, 2025
Member
Author
|
/deploy git-extra The i686/x86_64 and the arm64 workflow runs were started. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't get the
sdk build msys2-runtimepart of #627 quite right. This fixes it.