Skip to content

Allow nil filter settings#47

Merged
mjcheetham merged 1 commit intomainfrom
nil-filter-settings
Feb 12, 2026
Merged

Allow nil filter settings#47
mjcheetham merged 1 commit intomainfrom
nil-filter-settings

Conversation

@mjcheetham
Copy link
Contributor

@mjcheetham mjcheetham commented Feb 12, 2026

If you do no specify filter settings in the trace2receiver config then you hit a null pointer exception at runtime as we try to access the Keynames member of a nil *FilterSettings.

E.g.,

receivers:
  trace2receiver:
    pipe: "//./pipe/pipe-name"

If you do no specify filter settings in the trace2receiver config then
you hit a null pointer exception at runtime as we try to access the
`Keynames` member of a `nil` `*FilterSettings`.

Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
Copy link
Contributor

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mjcheetham mjcheetham merged commit 222a5ba into main Feb 12, 2026
9 checks passed
@mjcheetham mjcheetham deleted the nil-filter-settings branch February 12, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments