Repository navigation
Apply --rotate to SVG output - #168
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--rotate(the old--reverse) has no effect on--svgoutput.print_unicodechecksreverse_commit_order, butprint_svgnever reads it, so the SVG always has the newest commit on top.print_svgnow mirrors the rows when the flag is set:matrix(1 0 0 -1 0 H)transform that mirrors it around the same rows.--debugbranch lines use the mirrored row as well.Output without
--rotateis unchanged, andsvg_keeps_newest_commit_on_top_by_defaultchecks the order and that no transform is added.Fixes #134
What I ran, on macOS with rustc 1.98.1:
cargo test --lockedpasses. The two new tests insrc/print/svg.rsbuild a two-commit repo in the temp directory.svg_rotate_puts_oldest_commit_on_topfails without the change.cargo fmt --checkpasses, andcargo clippy --locked --all-targetsreports no warnings.I did not run the binary or open the SVG in a viewer, so the picture itself is unchecked. The tests only cover a linear history, so a graph with merges has not been exercised with
--rotate.