Repository navigation
fix: use the real PI services _GARB and _MODU for compress and copy RAM to ROM - #941
Merged
Merged
Conversation
gijzelaerr
force-pushed
the
fix-pi-service-names
branch
from
October 7, 2026 10:13
87918e7 to
5b08876
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #936.
build_compress_requestandbuild_copy_ram_to_rom_requestused an invented PI service_MSZL(with file idPfor copy RAM to ROM). The public CISAsnap7.pcaptrace, which the cold start and stop requests already match byte for byte, shows engineering tools sending:28 00 00 00 00 00 00 fd 00 00 05 5f 47 41 52 42(_GARB)28 00 00 00 00 00 00 fd 00 02 45 50 05 5f 4d 4f 44 55(file systemEP,_MODU)and native Snap7's
TReqFunCompress/TReqFunCopyRamToRomuse the same names. Both requests are now defined next to the start/stop parameter blocks and built throughbuild_plc_control_request(new operationscompressandcopy_ram_to_rom). The bundled server recognises the new services instead of_MSZL, and tests pin the exact parameter bytes from the capture.I have not tested against a physical PLC; this aligns the packets with the captured real jobs.