Improve semantic memory reinforcement and contradiction recall#3
Open
coe0718 wants to merge 3 commits intoghostwright:mainfrom
Open
Improve semantic memory reinforcement and contradiction recall#3coe0718 wants to merge 3 commits intoghostwright:mainfrom
coe0718 wants to merge 3 commits intoghostwright:mainfrom
Conversation
Ari4ka
approved these changes
Mar 31, 2026
d4c955f to
407b067
Compare
Contributor
Author
|
Rebased this morning. |
Ari4ka
approved these changes
Mar 31, 2026
imonlinux
added a commit
to imonlinux/phantom
that referenced
this pull request
Apr 24, 2026
Complete security review and implementation of fixes for Nextcloud Talk integration based on comprehensive security audit findings. HIGH PRIORITY fixes (security-critical): - ghostwright#1: Implement replay attack protection with LRU cache (5-minute TTL) - ghostwright#2: Add 64KB request size limit before body buffering - ghostwright#4: Replace Date.now() with crypto.randomUUID() for unique IDs - ghostwright#7: Fix JSON unwrap logic for ActivityStreams Note objects - ghostwright#11: Replace 'Error:' text sniffing with runtime error events Logic and security fixes: - ghostwright#3: Fix msgId/msg name collision in error handling - ghostwright#5: Improve parseConversationId to handle colons in tokens - ghostwright#6: Reject webhooks without target.id instead of silent fallback - ghostwright#8: Normalize emoji to avoid variation selector validation issues - ghostwright#9: Handle 404/409 reaction responses as success conditions - ghostwright#10: Make setReaction return boolean for proper error handling - ghostwright#12: Improve bot loop guard with actorId checking Best practices and polish: - ghostwright#13: Make port configurable instead of hardcoded 3200 - ghostwright#14: Move webhookPath default normalization to constructor - ghostwright#15: Fix health check path precedence (check webhook first) - ghostwright#16: Add exponential backoff retry for 5xx/429 responses - ghostwright#17: Add URL validation and encoding for talkServer config - ghostwright#18: Document HMAC signing asymmetry (inbound vs outbound) - ghostwright#20: Import randomUUID explicitly from node:crypto - ghostwright#21: Add reactions: true to channel capabilities - ghostwright#22: Namespace environment variables with NEXTCLOUD_ prefix Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
mcheemaa
added a commit
that referenced
this pull request
Apr 27, 2026
…This.fetch (B.1.4 fix-and-review #3) Round-3 fixes for the heartbeat + first DM landing. F-B14-E (P2): index.ts read process.env.SLACK_TRANSPORT verbatim before the agent_ready heartbeat. readSlackTransportFromEnv() trims its input, so a whitespace-padded SLACK_TRANSPORT=" http " booted the HTTP receiver while the gate skipped reportAgentReady, leaving the operator's readiness RPC waiting indefinitely. The factory and the gate now share the same normalized transport via the helper. F-B14-F (P2): slack-introduction.ts had the same raw-env mismatch on the first_dm_sent gate. Same helper applied here so a successful Slack DM is always paired with the audit signal in HTTP-transport boots. CI test: heartbeat.test.ts "POSTs to ..." tests for both reportAgentReady and reportFirstDmSent rewritten to use a globalThis.fetch override with scalar locals (no closure-captured array). The previous pattern passed on Bun 1.3.5 locally but failed on Bun 1.3.13 in CI; the rewrite is Bun-version-agnostic and the try/finally restore is mandatory so a mid-test failure does not leak the override into sibling tests. Tests: 1959 pass, 10 skip, 0 fail. Lint clean, typecheck clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
This PR improves semantic memory durability and contradiction visibility without introducing a new parallel memory system.
superseded_by_fact_idWhy
This is a follow-up step on the memory strategy discussed in #1.
Phantom already stores semantic facts and invalidates contradicted ones, but repeated facts still behaved like separate observations, and changed beliefs were not surfaced clearly during later retrieval. This PR keeps the work in the TypeScript plumbing lane:
The agent and judges still handle the reasoning side. This change just makes the stored semantic memory behave more like a durable knowledge layer.
How I Tested
Commands run:
Notes:
Checklist
bun test)bun run lint)bun run typecheck).envfiles included