Skip to content

fix(row-detail): support transform rows with overlay rendering - #2738

Merged
ghiscoding merged 6 commits into
masterfrom
refactor/row-detail-transform-top
Aug 18, 2026
Merged

fix(row-detail): support transform rows with overlay rendering#2738
ghiscoding merged 6 commits into
masterfrom
refactor/row-detail-transform-top

Conversation

@ghiscoding

@ghiscoding ghiscoding commented Aug 18, 2026

Copy link
Copy Markdown
Owner

Summary

Make Row Detail compatible with rowTopOffsetRenderType: 'transform' which is the default rendering grid option.

Previously, Row Detail panels were inserted inside transformed row elements. Because transformed rows establish their own coordinate system, detail panels could be positioned incorrectly or move with the wrong row offset.

This PR adds an overlay rendering mode that mounts Row Detail panels in a sibling overlay layer outside the transformed row DOM.

Changes

  • Added rowDetailView.renderMode: 'overlay'.
  • Positioned overlay panels using the grid’s calculated row offsets.
  • Added support for scrollable and frozen canvases.
  • Preserved framework component lifecycles across React, Vue, Angular, and Aurelia.
  • Removed unnecessary microtask scheduling from the overlay lifecycle.
  • Updated Row Detail examples and Cypress selectors.
  • Updated documentation.
  • Added framework-specific CI Cypress scripts.

Usage:

rowDetailView: {
  renderMode: 'overlay'
}

// this line is no longer needed since it now works with default transform
// rowTopOffsetRenderType: 'top', 

Backward compatibility

  • Existing applications continue using inline rendering by default.
  • renderMode: 'inline' remains available in v10 and is deprecated.
  • Explicit rowTopOffsetRenderType: 'top' remains supported for legacy compatibility and RowSpan scenarios.

v11 follow-up

Overlay rendering should become the only Row Detail renderer. The renderMode option, inline renderer, related compatibility branches, and Row Detail-specific rowTopOffsetRenderType: 'top' fallback can then be removed.

Verification

  • Row Detail unit tests: 54/54 passing
  • TypeScript, Prettier, and diff checks passed.
  • Framework Cypress suites were previously validated across Vanilla, React, Angular, and Aurelia.

LLM

OpenAI GPT-5.6 Terra and Luna (Codex).

@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (0be7225) to head (17312ab).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2738    +/-   ##
========================================
  Coverage   100.0%   100.0%            
========================================
  Files         200      200            
  Lines       25601    25713   +112     
  Branches     9046     9081    +35     
========================================
+ Hits        25601    25713   +112     
Flag Coverage Δ
angular 100.0% <ø> (ø)
universal 100.0% <100.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new

pkg-pr-new Bot commented Aug 18, 2026

Copy link
Copy Markdown
angular-slickgrid

npm i https://pkg.pr.new/angular-slickgrid@2738

aurelia-slickgrid

npm i https://pkg.pr.new/aurelia-slickgrid@2738

slickgrid-react

npm i https://pkg.pr.new/slickgrid-react@2738

slickgrid-vue

npm i https://pkg.pr.new/slickgrid-vue@2738

@slickgrid-universal/angular-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/angular-row-detail-plugin@2738

@slickgrid-universal/aurelia-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/aurelia-row-detail-plugin@2738

@slickgrid-universal/react-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/react-row-detail-plugin@2738

@slickgrid-universal/vue-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/vue-row-detail-plugin@2738

@slickgrid-universal/binding

npm i https://pkg.pr.new/@slickgrid-universal/binding@2738

@slickgrid-universal/common

npm i https://pkg.pr.new/@slickgrid-universal/common@2738

@slickgrid-universal/composite-editor-component

npm i https://pkg.pr.new/@slickgrid-universal/composite-editor-component@2738

@slickgrid-universal/custom-footer-component

npm i https://pkg.pr.new/@slickgrid-universal/custom-footer-component@2738

@slickgrid-universal/custom-tooltip-plugin

npm i https://pkg.pr.new/@slickgrid-universal/custom-tooltip-plugin@2738

@slickgrid-universal/empty-warning-component

npm i https://pkg.pr.new/@slickgrid-universal/empty-warning-component@2738

@slickgrid-universal/event-pub-sub

npm i https://pkg.pr.new/@slickgrid-universal/event-pub-sub@2738

@slickgrid-universal/excel-export

npm i https://pkg.pr.new/@slickgrid-universal/excel-export@2738

@slickgrid-universal/graphql

npm i https://pkg.pr.new/@slickgrid-universal/graphql@2738

@slickgrid-universal/odata

npm i https://pkg.pr.new/@slickgrid-universal/odata@2738

@slickgrid-universal/pagination-component

npm i https://pkg.pr.new/@slickgrid-universal/pagination-component@2738

@slickgrid-universal/pdf-export

npm i https://pkg.pr.new/@slickgrid-universal/pdf-export@2738

@slickgrid-universal/row-detail-view-plugin

npm i https://pkg.pr.new/@slickgrid-universal/row-detail-view-plugin@2738

@slickgrid-universal/rxjs-observable

npm i https://pkg.pr.new/@slickgrid-universal/rxjs-observable@2738

@slickgrid-universal/sql

npm i https://pkg.pr.new/@slickgrid-universal/sql@2738

@slickgrid-universal/text-export

npm i https://pkg.pr.new/@slickgrid-universal/text-export@2738

@slickgrid-universal/utils

npm i https://pkg.pr.new/@slickgrid-universal/utils@2738

@slickgrid-universal/vanilla-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-bundle@2738

@slickgrid-universal/vanilla-force-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-force-bundle@2738

@slickgrid-universal/web-mcp

npm i https://pkg.pr.new/@slickgrid-universal/web-mcp@2738

commit: 17312ab

Comment thread packages/row-detail-view-plugin/src/slickRowDetailView.ts Outdated
Comment thread packages/row-detail-view-plugin/src/slickRowDetailView.ts Outdated
Comment thread packages/row-detail-view-plugin/src/slickRowDetailView.ts
Comment thread packages/row-detail-view-plugin/src/slickRowDetailView.ts
Comment thread packages/row-detail-view-plugin/src/slickRowDetailView.ts Outdated
@ghiscoding
ghiscoding merged commit 1c76ae1 into master Aug 18, 2026
21 of 23 checks passed
@ghiscoding
ghiscoding deleted the refactor/row-detail-transform-top branch August 18, 2026 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant