fix(row-detail): support transform rows with overlay rendering - #2738
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2738 +/- ##
========================================
Coverage 100.0% 100.0%
========================================
Files 200 200
Lines 25601 25713 +112
Branches 9046 9081 +35
========================================
+ Hits 25601 25713 +112
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
angular-slickgrid
aurelia-slickgrid
slickgrid-react
slickgrid-vue
@slickgrid-universal/angular-row-detail-plugin
@slickgrid-universal/aurelia-row-detail-plugin
@slickgrid-universal/react-row-detail-plugin
@slickgrid-universal/vue-row-detail-plugin
@slickgrid-universal/binding
@slickgrid-universal/common
@slickgrid-universal/composite-editor-component
@slickgrid-universal/custom-footer-component
@slickgrid-universal/custom-tooltip-plugin
@slickgrid-universal/empty-warning-component
@slickgrid-universal/event-pub-sub
@slickgrid-universal/excel-export
@slickgrid-universal/graphql
@slickgrid-universal/odata
@slickgrid-universal/pagination-component
@slickgrid-universal/pdf-export
@slickgrid-universal/row-detail-view-plugin
@slickgrid-universal/rxjs-observable
@slickgrid-universal/sql
@slickgrid-universal/text-export
@slickgrid-universal/utils
@slickgrid-universal/vanilla-bundle
@slickgrid-universal/vanilla-force-bundle
@slickgrid-universal/web-mcp
commit: |
ghiscoding
commented
Aug 18, 2026
ghiscoding
commented
Aug 18, 2026
ghiscoding
commented
Aug 18, 2026
ghiscoding
commented
Aug 18, 2026
ghiscoding
commented
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make Row Detail compatible with
rowTopOffsetRenderType: 'transform'which is the default rendering grid option.Previously, Row Detail panels were inserted inside transformed row elements. Because transformed rows establish their own coordinate system, detail panels could be positioned incorrectly or move with the wrong row offset.
This PR adds an overlay rendering mode that mounts Row Detail panels in a sibling overlay layer outside the transformed row DOM.
Changes
rowDetailView.renderMode: 'overlay'.Usage:
Backward compatibility
renderMode: 'inline'remains available in v10 and is deprecated.rowTopOffsetRenderType: 'top'remains supported for legacy compatibility and RowSpan scenarios.v11 follow-up
Overlay rendering should become the only Row Detail renderer. The
renderModeoption, inline renderer, related compatibility branches, and Row Detail-specificrowTopOffsetRenderType: 'top'fallback can then be removed.Verification
LLM
OpenAI GPT-5.6 Terra and Luna (Codex).