Skip to content

refactor!: drop SortableJS dependency#2634

Draft
ghiscoding wants to merge 4 commits into
masterfrom
refactor/drop-sortablejs
Draft

refactor!: drop SortableJS dependency#2634
ghiscoding wants to merge 4 commits into
masterfrom
refactor/drop-sortablejs

Conversation

@ghiscoding

@ghiscoding ghiscoding commented Jun 30, 2026

Copy link
Copy Markdown
Owner

vibe coded with copilot using Claude Sonnet 4.6

I first tried to migrate from SortableJS to @formkit/drag-and-drop in another branch refactor/formkit-dnd but copilot suggested that we could actually drop the use of any external dependency and use native code with about ~350 loc. Note that this wouldn't get merged until the next major version (next year) since that could impact some E2E tests (I had to add a custom Cypress drag command to make my tests pass).

Comparing the build size of my Salesforce standalone script zip file, dropping SortableJS drops about ~10Kb (as a comparison, when I tried to migrate to @formkit/drag-and-drop, that dropped only about ~2.5Kb, so dropping SortableJS entirely has a much larger decrease in size).

TODOs

  • not working with touch and drag
  • issues remaining with Firefox Linux
    • problems with Header Menu, Column Picker
    • !(e.target as HTMLElement)?.closest('.slick-header-menu-button')

@ghiscoding ghiscoding marked this pull request as draft June 30, 2026 22:38
@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (3567aab) to head (14c1d27).

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2634    +/-   ##
========================================
  Coverage   100.0%   100.0%            
========================================
  Files         200      201     +1     
  Lines       25313    25631   +318     
  Branches     8951     9029    +78     
========================================
+ Hits        25313    25631   +318     
Flag Coverage Δ
angular 100.0% <ø> (ø)
universal 100.0% <100.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ghiscoding

ghiscoding commented Jun 30, 2026

Copy link
Copy Markdown
Owner Author

converting to Draft since I mainly want to see if all tests are passing, if confirmed then I'll probably close the branch and just resurrect it in our next major version in 2027-Q1. I mainly wanted to use my leftover copilot tokens before the next month rolls in

cc @zewa666

EDIT

After trying it on my linux laptop, I had to patch a few things for Firefox Linux, and also told the AI to patch for any Safari issues as well. Now it's still shaving 10Kb from my zip file but it's now increased from 100 loc to 350 loc (as per codecov), probably still worth it but quite different compared to the original AI assumption 🤔

EDIT 2

hmm I found some more issues mostly with Firefox Linux, but also issues in other browsers with touch though it works fine with touch and SortableJS. I might give up on this trial, the other lib also has problems with touch, so it seems SortableJS is still better even if bigger

@pkg-pr-new

pkg-pr-new Bot commented Jun 30, 2026

Copy link
Copy Markdown
angular-slickgrid

npm i https://pkg.pr.new/angular-slickgrid@2634

aurelia-slickgrid

npm i https://pkg.pr.new/aurelia-slickgrid@2634

slickgrid-react

npm i https://pkg.pr.new/slickgrid-react@2634

slickgrid-vue

npm i https://pkg.pr.new/slickgrid-vue@2634

@slickgrid-universal/angular-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/angular-row-detail-plugin@2634

@slickgrid-universal/aurelia-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/aurelia-row-detail-plugin@2634

@slickgrid-universal/react-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/react-row-detail-plugin@2634

@slickgrid-universal/vue-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/vue-row-detail-plugin@2634

@slickgrid-universal/binding

npm i https://pkg.pr.new/@slickgrid-universal/binding@2634

@slickgrid-universal/common

npm i https://pkg.pr.new/@slickgrid-universal/common@2634

@slickgrid-universal/composite-editor-component

npm i https://pkg.pr.new/@slickgrid-universal/composite-editor-component@2634

@slickgrid-universal/custom-footer-component

npm i https://pkg.pr.new/@slickgrid-universal/custom-footer-component@2634

@slickgrid-universal/custom-tooltip-plugin

npm i https://pkg.pr.new/@slickgrid-universal/custom-tooltip-plugin@2634

@slickgrid-universal/empty-warning-component

npm i https://pkg.pr.new/@slickgrid-universal/empty-warning-component@2634

@slickgrid-universal/event-pub-sub

npm i https://pkg.pr.new/@slickgrid-universal/event-pub-sub@2634

@slickgrid-universal/excel-export

npm i https://pkg.pr.new/@slickgrid-universal/excel-export@2634

@slickgrid-universal/graphql

npm i https://pkg.pr.new/@slickgrid-universal/graphql@2634

@slickgrid-universal/odata

npm i https://pkg.pr.new/@slickgrid-universal/odata@2634

@slickgrid-universal/pagination-component

npm i https://pkg.pr.new/@slickgrid-universal/pagination-component@2634

@slickgrid-universal/pdf-export

npm i https://pkg.pr.new/@slickgrid-universal/pdf-export@2634

@slickgrid-universal/row-detail-view-plugin

npm i https://pkg.pr.new/@slickgrid-universal/row-detail-view-plugin@2634

@slickgrid-universal/rxjs-observable

npm i https://pkg.pr.new/@slickgrid-universal/rxjs-observable@2634

@slickgrid-universal/sql

npm i https://pkg.pr.new/@slickgrid-universal/sql@2634

@slickgrid-universal/text-export

npm i https://pkg.pr.new/@slickgrid-universal/text-export@2634

@slickgrid-universal/utils

npm i https://pkg.pr.new/@slickgrid-universal/utils@2634

@slickgrid-universal/vanilla-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-bundle@2634

@slickgrid-universal/vanilla-force-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-force-bundle@2634

@slickgrid-universal/web-mcp

npm i https://pkg.pr.new/@slickgrid-universal/web-mcp@2634

commit: 14c1d27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant