refactor!: drop SortableJS dependency#2634
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2634 +/- ##
========================================
Coverage 100.0% 100.0%
========================================
Files 200 201 +1
Lines 25313 25631 +318
Branches 8951 9029 +78
========================================
+ Hits 25313 25631 +318
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
converting to Draft since I mainly want to see if all tests are passing, if confirmed then I'll probably close the branch and just resurrect it in our next major version in 2027-Q1. I mainly wanted to use my leftover copilot tokens before the next month rolls in cc @zewa666 EDIT After trying it on my linux laptop, I had to patch a few things for Firefox Linux, and also told the AI to patch for any Safari issues as well. Now it's still shaving 10Kb from my zip file but it's now increased from 100 loc to 350 loc (as per codecov), probably still worth it but quite different compared to the original AI assumption 🤔 EDIT 2 hmm I found some more issues mostly with Firefox Linux, but also issues in other browsers with touch though it works fine with touch and SortableJS. I might give up on this trial, the other lib also has problems with touch, so it seems SortableJS is still better even if bigger |
angular-slickgrid
aurelia-slickgrid
slickgrid-react
slickgrid-vue
@slickgrid-universal/angular-row-detail-plugin
@slickgrid-universal/aurelia-row-detail-plugin
@slickgrid-universal/react-row-detail-plugin
@slickgrid-universal/vue-row-detail-plugin
@slickgrid-universal/binding
@slickgrid-universal/common
@slickgrid-universal/composite-editor-component
@slickgrid-universal/custom-footer-component
@slickgrid-universal/custom-tooltip-plugin
@slickgrid-universal/empty-warning-component
@slickgrid-universal/event-pub-sub
@slickgrid-universal/excel-export
@slickgrid-universal/graphql
@slickgrid-universal/odata
@slickgrid-universal/pagination-component
@slickgrid-universal/pdf-export
@slickgrid-universal/row-detail-view-plugin
@slickgrid-universal/rxjs-observable
@slickgrid-universal/sql
@slickgrid-universal/text-export
@slickgrid-universal/utils
@slickgrid-universal/vanilla-bundle
@slickgrid-universal/vanilla-force-bundle
@slickgrid-universal/web-mcp
commit: |
vibe coded with copilot using Claude Sonnet 4.6
I first tried to migrate from SortableJS to
@formkit/drag-and-dropin another branchrefactor/formkit-dndbut copilot suggested that we could actually drop the use of any external dependency and use native code with about ~350 loc. Note that this wouldn't get merged until the next major version (next year) since that could impact some E2E tests (I had to add a custom Cypress drag command to make my tests pass).Comparing the build size of my Salesforce standalone script zip file, dropping SortableJS drops about ~10Kb (as a comparison, when I tried to migrate to
@formkit/drag-and-drop, that dropped only about ~2.5Kb, so dropping SortableJS entirely has a much larger decrease in size).TODOs
!(e.target as HTMLElement)?.closest('.slick-header-menu-button')