Allow NextSegment() to be called across multiple Process() calls in the Go binding #3503
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue in the Go bindings where calling
NextSegment()after multipleProcess()invocations returns no new segments. This prevented incremental or streaming-style processing from functioning correctly.Details
When the Go wrapper calls
Process()more than once, the internal context segment counter (context.n) is not reset or updated properly. As a result:NextSegment()stops yielding new segments after the firstProcess()call.This PR resets
context.nat the start of eachProcess()call, ensuring that segment iteration works correctly across multiple processing passes.Impact
whisper.cppcore behavior.Backward Compatibility
This change is internal to the Go bindings and does not modify the public API.
Existing code using a single
Process()→NextSegment()workflow will behave exactly as before.