hal/vulkan: fix invalid request of VK_EXT_physical_device_drm as an instance extension #8554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstance extension It's a device extension [1], so this fails 100% of the time. The comment above mentions VK_KHR_get_physical_device_properties2, which _is_ an instance extension [2], so let's check for that instead. [1]: https://docs.vulkan.org/refpages/latest/refpages/source/VK_EXT_physical_device_drm.html [2]: https://docs.vulkan.org/refpages/latest/refpages/source/VK_KHR_get_physical_device_properties2.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's a device extension 1, so this fails 100% of the time.
The comment above mentions
VK_KHR_get_physical_device_properties2, which is an instance extension 2, so let's check for that instead.Testing
It compiles 😅
The previous code was clearly invalid so deleting it is definitely correct; replacing it as described above seems sensible, but I haven't checked what
VK_KHR_get_physical_device_properties2is needed for, so maybe it's not needed either, in which case I'm also happy to just delete it :)Squash or Rebase?
N/A
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.