Skip to content

fix(config): Inherit org execution defaults for repo skills - #514

Open
gricha wants to merge 1 commit into
mainfrom
fix/inherit-org-model-defaults
Open

fix(config): Inherit org execution defaults for repo skills#514
gricha wants to merge 1 commit into
mainfrom
fix/inherit-org-model-defaults

Conversation

@gricha

@gricha gricha commented Aug 22, 2026

Copy link
Copy Markdown
Member

Let repo-local skills inherit agent, auxiliary, and synthesis execution defaults from the org base config when they omit them. This covers both the nested configuration and the legacy model, turn-limit, and auxiliary-retry fields.

Layered resolution currently isolates repo-local skills from these defaults. An omitted model can therefore fall through to the environment or SDK default even when the org base config selects a model. In production this allowed repo-local skills to run on K2.6 while the org security review ran on Grok.

Explicit repo settings retain precedence. Reporting thresholds, path filters, and other policy defaults remain layer-local, preserving the separation between org-enforced and repo-owned skills.

The alternative in getsentry/.github#211 sets a global model fallback. That covers an omitted primary model, but it cannot carry effort, turn limits, auxiliary settings, or synthesis settings and leaves the layered configuration behavior surprising.

Let repo-local skills inherit base agent, auxiliary, and synthesis defaults when omitted.

Preserve explicit repo overrides across nested and legacy config fields.
Keep policy defaults isolated.

Co-Authored-By: GPT-5.6 Sol <noreply@anthropic.com>

@sentry-junior sentry-junior Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The implementation limits inheritance to execution settings, normalizes legacy and nested fields before applying repo precedence, and the regression coverage checks both inheritance and explicit overrides.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant