Repository navigation
fix(cli): trace view unable to fetch span warning when using --full/--json - #1577
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
lzhao-sentry
marked this pull request as ready for review
October 21, 2026 17:50
betegon
self-requested a review
October 21, 2026 17:53
betegon
deleted the
lzhao/fix/allow-string-type-trace-item-attr-schema
branch
October 21, 2026 18:06
Member
|
@lzhao-sentry thanks so much! @betegon @MathurAditya724 - any idea why we cannot get the proper types from the API spec repo? |
Member
|
Yes @BYK, this endpoint is not public, that's why we're using our own types. It's private on We have an option called |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Noticed that when you pass
--fullor--jsonto thetrace viewcommand, every span gives a warning "Could not fetch details of ..."Seems like when fetching int attributes, they can be returned as strings if the number is too large (i.e., project ids). So this PR fixes that by allowing string values in the schema.