Repository navigation
feat(cli): add attribute list command - #1559
Draft
lzhao-sentry wants to merge 2 commits into
Draft
lzhao-sentry wants to merge 2 commits into
lzhao-sentry wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
BYK
requested changes
Oct 20, 2026
BYK
left a comment
BYK
left a comment
Member
There was a problem hiding this comment.
Pre-emptively blocking to do a quick design review (mostly UX)
| # Attributes seen on the same spans as the specified attribute | ||
| sentry attribute list --with gen_ai.request.model | ||
|
|
||
| # Add descriptions, example values, and deprecation info |
Member
There was a problem hiding this comment.
Suggested change
| # Add descriptions, example values, and deprecation info | |
| # Show descriptions, example values, and deprecation info |
| # Attributes seen on the same spans as the specified attribute | ||
| sentry attribute list --with gen_ai.request.model | ||
|
|
||
| # Add descriptions, example values, and deprecation info |
Member
There was a problem hiding this comment.
Suggested change
| # Add descriptions, example values, and deprecation info | |
| # Show descriptions, example values, and deprecation info |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds a top level
attribute listcommand to CLI as part of an effort to clean up and expose attributes for both users and agents.Some design choices:
--withinstead of--query. Thequeryparam for attribute API doesn't use Sentry query syntax, rather it's just searching attribute keys that appear with the queried keys on same spans, logs, etc--cursorfor now as the attribute API pagination works differently from other APIs (see comments inlist.ts), so it wouldn't be consistent to add pagination as is. Instead attribute filtering is encouraged with--with/--search/--type