Repository navigation
fix(cli): Install Homebrew completions from the formula - #1555
Open
sentry-junior[bot] wants to merge 1 commit into
Open
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
Homebrew runs post_install under a throwaway HOME, so the `sentry cli setup` call there wrote completions, agent skills, and install metadata into a temp dir that was deleted right after. Generate completions into Homebrew's own completion dirs during install, drop the no-op post_install, and add caveats telling users to run `sentry cli setup` for agent skills. Update docs that claimed Homebrew installs skills automatically. Fixes #1545 Co-Authored-By: byk <burak.kaya@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
BYK
approved these changes
Oct 20, 2026
BYK
marked this pull request as ready for review
October 20, 2026 16:39
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1545.
Homebrew runs
post_installunder a temporaryHOMEand deletes it afterwards. So the formula'ssentry cli setup --method brew --no-modify-pathwrote completions, agent skills, and install metadata into a directory that was thrown away.Changes to the formula template in
.craft.yml:installwithgenerate_completions_from_executable(bin/"sentry", "cli", "completion"), which writes them to Homebrew's own bash/zsh/fish completion dirs. These persist, andbrew uninstallremoves them.post_installremoved: it never left anything behind. Removing it also gets rid of Homebrew'spost_installdeprecation warning.sentry cli setup --no-modify-path --no-completionsto install the agent skill, and to run it again afterbrew upgrade.sentry cli upgradealready reruns setup by itself.The install-method record doesn't need a replacement: the CLI already detects Homebrew from the Cellar realpath before it reads stored info.
The docs (
getting-started.mdx,agentic-usage.md,plugins/README.md) no longer say Homebrew installs agent skills automatically, and they now show the manual step.This only reaches users with the next CLI release, when craft regenerates
getsentry/homebrew-tools/Formula/sentry.rb.Still a draft: the formula hasn't been tested with a real
brew installon macOS.via byk.
--
View Junior Session in Sentry