Skip to content

fix(cli): retry interrupted GET responses across commands - #1548

Merged
betegon merged 3 commits into
mainfrom
bt/cli-retry-response-body
Oct 20, 2026
Merged

betegon merged 3 commits into
mainfrom
bt/cli-retry-response-body

Conversation

@betegon

@betegon betegon commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

HTTP 200 could leave an interrupted response body outside the CLI's retry loop, causing TypeError: terminated in sentry api and other commands (CLI-294). Complete finite GET bodies within the existing three-attempt retry and timeout budget across generated SDK operations and handwritten API helpers.

An SDK request interceptor carries parsing intent into the shared transport, which remains the only retry owner. Explicit streams, automatic stream responses, and SSE stay streaming; successful mutations are not replayed for body errors. JSON parsing and validation remain outside retries. The original Response, headers, binary bytes, and discovery provenance are preserved.

Validation: 21 regression cases covering raw/manual/SDK requests, issue pagination, replay segments, cancellation, timeouts and streaming. Disabling body recovery fails the selected manual/raw/issue-list tests; forcing default buffering fails the streaming-isolation test. Full typecheck, lint and test gates pass.

@vercel

vercel Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
sentry-local Skipped Skipped Oct 20, 2026 3:23pm UTC

Request Review

@betegon betegon changed the title fix(cli): retry interrupted raw API GET responses fix(cli): retry interrupted GET responses across commands Oct 20, 2026
@betegon
betegon marked this pull request as ready for review October 20, 2026 14:33
@github-actions github-actions Bot added the risk: medium PR risk score: medium label Oct 20, 2026
@betegon
betegon force-pushed the bt/cli-retry-response-body branch from 7fbe290 to 4172910 Compare October 20, 2026 14:37
@betegon
betegon force-pushed the bt/cli-retry-response-body branch from 4172910 to e42f0f4 Compare October 20, 2026 14:43
@betegon
betegon force-pushed the bt/cli-retry-response-body branch from c48e9b8 to 34a146b Compare October 20, 2026 15:23
@betegon
betegon merged commit 02e75ba into main Oct 20, 2026
26 checks passed
@betegon
betegon deleted the bt/cli-retry-response-body branch October 20, 2026 15:53

This branch was previously deployed

1 inactive deployment
Preview — 34a146b6 Deployed Oct 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: medium PR risk score: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant