Conversation
| .replace("sync", "s"); | ||
| .replace("sync", "s") | ||
| .replace("stdio", "io") | ||
| .replace("sse", "sse"); |
Check warning
Code scanning / CodeQL
Replacement of a substring with itself Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 9 days ago
In general, to fix a “replacement of a substring with itself” issue, either remove the redundant .replace call if no transformation is needed, or change the replacement string so it reflects the intended transformation. Here, we should avoid changing the program’s behavior beyond removing the no-op; altering the output for "sse" (e.g., to "se" or "e") would be speculative and might break expectations elsewhere.
The best minimal fix is therefore to delete the .replace("sse", "sse") call from the abbreviateMode function in .github/scripts/compare-ctrf.cjs. This keeps the existing abbreviations unchanged and simply stops doing a useless, confusing operation. Concretely, update the function body so it ends with .replace("lowlevel", "lo") as the last replacement. No new imports, methods, or additional definitions are required.
| @@ -365,8 +365,7 @@ | ||
| .replace("sync", "s") | ||
| .replace("stdio", "io") | ||
| .replace("highlevel", "hi") | ||
| .replace("lowlevel", "lo") | ||
| .replace("sse", "sse"); | ||
| .replace("lowlevel", "lo"); | ||
| } | ||
|
|
||
| // Group all tests by type, separately for main and PR |
🔴 AI SDK Integration Test ResultsStatus: 3 regressions detected Summary
🔴 RegressionsThese tests were passing on main but are now failing: node/langchain :: Multi-Turn LLM Test (streaming)Error: 1 check(s) failed: node/langchain :: Multi-Turn LLM Test (blocking)Error: 1 check(s) failed: node/openai :: Multi-Turn LLM Test (blocking)Error: 1 check(s) failed: ✅ FixedThese tests were failing on main but are now passing:
🆕 New TestsPassing (36):
Failing (4): ❌ python/mcp :: Basic MCP Tool Call Test (async, blocking, sse, lowlevel)Error: 1 check(s) failed: ❌ python/mcp :: MCP Multiple Tool Calls Test (async, blocking, sse, lowlevel)Error: 2 check(s) failed: ❌ python/mcp :: MCP Resource Read Test (async, blocking, sse, lowlevel)Error: 1 check(s) failed: ❌ python/mcp :: MCP Prompt Get Test (async, blocking, sse, lowlevel)Error: 1 check(s) failed: Test MatrixAgent Tests
Embedding Tests
LLM Tests
MCP Tests
Legend: ✅ Pass | ❌ Fail | ✅🔧 Fixed | ❌📉 Regressed | ✅🆕 New (pass) | ❌🆕 New (fail) | 🗑️ Removed | str=streaming blk=blocking a=async s=sync io=stdio sse=sse hi=highlevel lo=lowlevel Generated by AI SDK Integration Tests |
Adding capability to add generic options that are propagated to the templates
Closes https://linear.app/getsentry/issue/TET-1871/ai-testing-framework-add-mcp-type