Skip to content

chore: pin GitHub Actions to full-length commit SHAs #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshuarli wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: pin GitHub Actions to full-length commit SHAs #579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/fast-revert.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
steps:
- name: Get auth token
id: token
uses: getsentry/action-github-app-token@v3.0.0
uses: getsentry/action-github-app-token@d4b5da6c5e37703f8c3b3e43abb5705b46e159cc # v3.0.0
with:
app_id: ${{ vars.FAST_REVERT_BOT_APP_ID }}
private_key: ${{ secrets.GH_FAST_REVERT_PRIVATE_KEY }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ jobs:

steps:
- name: Run Sentry self-hosted e2e CI
uses: getsentry/self-hosted@master
uses: getsentry/self-hosted@871c182cb0a99dc1fad72cc7ce7889b514b0c5f0 # master
with:
project_name: taskbroker
image_url: ghcr.io/getsentry/taskbroker:${{ github.sha }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-client.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
app-id: ${{ vars.SENTRY_RELEASE_BOT_CLIENT_ID }}
private-key: ${{ secrets.SENTRY_RELEASE_BOT_PRIVATE_KEY }}

- uses: actions/checkout@v4
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
Copy link
Copy Markdown

@cursor cursor bot Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent checkout v4 SHA across workflow files

Low Severity

The newly pinned actions/checkout SHA 34e114876b0b11c390a56381ad16ebd13914f8d5 (labelled # v4) differs from the SHA 11bd71901bbe5b1630ceea73d27597364c9af683 already used for actions/checkout v4 in ci.yml, image.yml, and python-example-image.yml. This means different workflow files reference different versions of the same action while both claiming to be v4, which could lead to subtle behavioral differences between CI and release workflows.

Additional Locations (1)
Fix in Cursor Fix in Web

with:
token: ${{ steps.token.outputs.token }}
fetch-depth: 0
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
with:
app-id: ${{ vars.SENTRY_RELEASE_BOT_CLIENT_ID }}
private-key: ${{ secrets.SENTRY_RELEASE_BOT_PRIVATE_KEY }}
- uses: actions/checkout@v4
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
with:
token: ${{ steps.token.outputs.token }}
fetch-depth: 0
Expand Down
Loading