fix(profiling): Validate profiler IDs before chunk queries - #122109
Draft
cvxluo wants to merge 1 commit into
Draft
fix(profiling): Validate profiler IDs before chunk queries#122109cvxluo wants to merge 1 commit into
cvxluo wants to merge 1 commit into
Conversation
Chunk endpoints passed arbitrary strings to Snuba UUID columns. Malformed input then surfaced as an internal query error. Validate and canonicalize the identifier at the API boundary and publish its UUID format. Fixes SENTRY-5N33 Co-authored-by: Codex <noreply@openai.com>
github-actions
Bot
added
the
Scope: Backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately this endpoint is a little sparse on types since we're retrieving things from vroom, but we should probably return a 400 instead of a 500 when someone passes an invalid UUID.
Fixes SENTRY-5N33