feat(onboarding): Support grouped options in ScmVirtualizedMenuList - #122103
Draft
jaydgoss wants to merge 1 commit into
Draft
feat(onboarding): Support grouped options in ScmVirtualizedMenuList#122103jaydgoss wants to merge 1 commit into
jaydgoss wants to merge 1 commit into
Conversation
This was referenced Aug 14, 2026
Contributor
📊 Type Coverage Diff
🔍 4 new type safety issues introduced
This is informational only and does not block the PR. |
jaydgoss
force-pushed
the
jaygoss/scm-virtualized-menu-groups
branch
from
August 14, 2026 22:49
dc37a6e to
666f185
Compare
Contributor
Sentry Snapshot Testing
|
jaydgoss
force-pushed
the
jaygoss/scm-platform-picker-alpha
branch
from
August 14, 2026 23:18
658ea9f to
2621d52
Compare
jaydgoss
force-pushed
the
jaygoss/scm-virtualized-menu-groups
branch
from
August 14, 2026 23:18
666f185 to
f88eab6
Compare
react-select renders each option group as a single Group element wrapping its Option children, which the virtualizer would treat as one fixed-height row. Flatten groups into heading and option rows, measured per row since headings differ in height from options. Flat option lists render exactly as before. Prepares the SCM platform picker for a sectioned dropdown.
jaydgoss
force-pushed
the
jaygoss/scm-virtualized-menu-groups
branch
from
August 14, 2026 23:23
f88eab6 to
fcec062
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
ScmVirtualizedMenuListcan now render react-select grouped options, with section headings and options each becoming one virtualized row. Flat option lists render exactly as before.Details
react-select renders each option group as a single
Groupelement wrapping all of itsOptionchildren, so the row-per-child virtualizer would treat an entire section as one 36px row. The menu list now flattensGroupchildren into heading and option rows, rendering headings the way react-select's ownGroupdoes so the core Select'sgroupHeadingstyles still apply.Rows are measured on mount (
measureElement) instead of assuming a fixed height, since headings are shorter than options and an empty-label heading collapses to zero, andgetItemKeykeeps those measurements attached to rows when filtering shifts the list. Keyboard-focus scrolling maps the focused option to its flattened row index, so headings count toward the scroll target. The next PR in the stack uses this to section the SCM platform picker.Stack