Skip to content

fix(scm-messaging-integration-ui): Enable picking from multiple integ… - #122092

Draft
Abdkhan14 wants to merge 6 commits into
abdk/provider-channel-assignmentfrom
abdk/picking-from-multiple-integrations
Draft

fix(scm-messaging-integration-ui): Enable picking from multiple integ…#122092
Abdkhan14 wants to merge 6 commits into
abdk/provider-channel-assignmentfrom
abdk/picking-from-multiple-integrations

Conversation

@Abdkhan14

@Abdkhan14 Abdkhan14 commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

...rations.

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 14, 2026
@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

📊 Type Coverage Diff

✅ no issues found

@Abdkhan14
Abdkhan14 marked this pull request as ready for review August 14, 2026 22:52
@Abdkhan14
Abdkhan14 requested a review from a team as a code owner August 14, 2026 22:52
Comment thread static/app/components/onboarding/scm/scmMessagingChannelPicker.tsx

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c619998. Configure here.

setSelectedIntegrationId(undefined);
setChannel(undefined);
}
}, [eligibleIntegrations, selectedIntegrationId]);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale channel after default workspace removal

Medium Severity

The workspace-removal effect only clears the channel when an explicit selectedIntegrationId disappears. When the effective workspace comes from defaultIntegration (saved or first, with selectedIntegrationId still undefined) and that workspace drops out of eligibleIntegrations, the derived workspace falls back but the channel is left in place. Saving can then pair the old channel with a different integrationId.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit c619998. Configure here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is valid taking a look

@Abdkhan14
Abdkhan14 marked this pull request as draft August 14, 2026 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant