test(snuba): accept DateTime meta without Universal spelling - #122091
Open
phacops wants to merge 3 commits into
Open
test(snuba): accept DateTime meta without Universal spelling#122091phacops wants to merge 3 commits into
phacops wants to merge 3 commits into
Conversation
clickhouse-connect reports DateTime / DateTime('UTC'). Production
get_json_type already treats any DateTime(...) as a date. Normalize
test comparisons so they pass against both the old driver spelling
and the HTTP driver.
github-actions
Bot
added
the
Scope: Backend
onewland
approved these changes
Aug 14, 2026
Strip DateTime timezone args from Snuba result meta so we do not leak driver protocol spellings like DateTime('UTC') or DateTime('Universal'). Time columns are just datetime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Snuba is dropping clickhouse-driver. Result meta for UTC timestamps will be
DateTimeorDateTime('UTC'), notDateTime('Universal').get_json_typealready maps anyDateTime(...)to"date". Tests were pinned to the old driver spelling.What
DateTimeas a date inget_json_typeNeeded so getsentry/snuba#8307 sentry CI does not fail on exact meta strings.