ref(span-buffer): Update path compression for existing span ids#117890
Draft
cmanallen wants to merge 2 commits into
Draft
ref(span-buffer): Update path compression for existing span ids#117890cmanallen wants to merge 2 commits into
cmanallen wants to merge 2 commits into
Conversation
github-actions
Bot
added
the
Scope: Backend
cmanallen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to traverse to the root-node in order to build the tree. For spans received in the current segment they will all be cached in redis with this span-id pointing to the best-known root node. Previously once inserted they were not updated again. However, this led to repeated traversals across nodes whose root was previously known. With this change we cache the root span id on the traversed nodes not in the segment set. This requires a few more operations (appended to the batch hset op) but no additional memory.
The diff is a little messed up. The old loop is untouched. A new loop is the only addition.