ref(preprod): Generalize size retention cutoff helper name#117864
Draft
jamieQ wants to merge 1 commit into
Draft
ref(preprod): Generalize size retention cutoff helper name#117864jamieQ wants to merge 1 commit into
jamieQ wants to merge 1 commit into
Conversation
get_size_retention_cutoff is applied to all preprod builds, including distribution/snapshot artifacts, not just size analysis. Rename it to get_preprod_artifact_retention_cutoff (and the matching DEFAULT_PREPROD_ARTIFACT_RETENTION_DAYS constant) so the name reflects its actual use. No behavior change; the retention window still derives from the SIZE_ANALYSIS data category. Refs #117539 Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the review on #117539:
get_size_retention_cutoffis applied to all preprod builds — including distribution/snapshot artifacts, not just size analysis — so the "size" name was misleading at its call sites.This renames the helper to
get_preprod_artifact_retention_cutoffand the siblingDEFAULT_SIZE_RETENTION_DAYSconstant toDEFAULT_PREPROD_ARTIFACT_RETENTION_DAYS, updating all 8 call sites and their tests.No behavior change — the retention window still derives from the
SIZE_ANALYSISdata category, which is the shared retention rule for both size and distribution builds.Refs #117539