ref(nav): Standardize primary nav footer button sizes#110289
Merged
Conversation
All buttons in the primary nav footer ButtonBar now use size='sm' consistently. Previously, the onboarding and user dropdown buttons used size='sm' while the service incidents, whats new, and help buttons had no explicit size set. Also adds a size prop to SidebarMenu so it can be forwarded to NavButton. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Frontend
natemoo-re
approved these changes
Mar 10, 2026
Member
natemoo-re
left a comment
natemoo-re
left a comment
There was a problem hiding this comment.
I seem to remember seeing a styled override to handle button sizes in #109977—any chance we can remove that now?
Otherwise LGTM!
Member
Author
Almost - we still need it because of a tiny quirk with the avatarButton, but let me do a followup to try and remove it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that one of the buttons had a 2px larger border radius, which then turned into me realizing that the button size prop had not been set 😅