Skip to content

feat(size): Ensure builds endpoint has parity with list-builds endpoint#110270

Merged
NicoHinderling merged 2 commits intomasterfrom
03-09-feat_size_ensure_builds_endpoint_has_parity_with_list-builds_endpoint
Mar 10, 2026
Merged

feat(size): Ensure builds endpoint has parity with list-builds endpoint#110270
NicoHinderling merged 2 commits intomasterfrom
03-09-feat_size_ensure_builds_endpoint_has_parity_with_list-builds_endpoint

Conversation

@NicoHinderling
Copy link
Contributor

@NicoHinderling NicoHinderling commented Mar 9, 2026

in preparation for moving only remaining user of list-builds endpoint to the builds endpoint

artifact_search.py — Added state to the search config so the builds endpoint can filter
by artifact state via query string (e.g. state:3), replacing the dedicated state param
the old list-builds endpoint had.

builds.py — Three changes for parity with the list-builds endpoint it replaces:

  1. Added select_related/prefetch_related to avoid N+1 queries during artifact
    transformation
  2. Set default_per_page=25, max_per_page=100 to match list-builds pagination
  3. Added per-artifact error handling in on_results so one bad artifact doesn't break
    the whole response

Copy link
Contributor Author

NicoHinderling commented Mar 9, 2026

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 9, 2026
@NicoHinderling NicoHinderling marked this pull request as ready for review March 9, 2026 23:10
@NicoHinderling NicoHinderling requested a review from a team as a code owner March 9, 2026 23:10
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@NicoHinderling NicoHinderling force-pushed the 03-09-feat_size_ensure_builds_endpoint_has_parity_with_list-builds_endpoint branch from ab6b708 to 6376d14 Compare March 9, 2026 23:19
Copy link
Contributor

@chromy chromy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % 1 comment - thanks!

@NicoHinderling NicoHinderling force-pushed the 03-09-feat_size_ensure_builds_endpoint_has_parity_with_list-builds_endpoint branch from 6376d14 to bca9d97 Compare March 10, 2026 20:53
@NicoHinderling NicoHinderling merged commit dbd8ac7 into master Mar 10, 2026
56 checks passed
@NicoHinderling NicoHinderling deleted the 03-09-feat_size_ensure_builds_endpoint_has_parity_with_list-builds_endpoint branch March 10, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants