ref(models): Delete CodeReviewEvent table [2/3]#109422
Merged
Conversation
github-actions
bot
added
the
Scope: Backend
vaind
force-pushed
the
ref/delete-code-review-event
branch
from
f80c6c9 to
7e4c976
Compare
wedamija
approved these changes
Feb 26, 2026
Contributor
|
This PR has a migration; here is the generated SQL for for --
-- Moved model CodeReviewEvent to pending deletion state
--
-- (no-op)for --
-- Delete model CodeReviewEvent
--
DROP TABLE "sentry_code_review_event" CASCADE; |
vaind
force-pushed
the
ref/delete-code-review-event
branch
from
7e4c976 to
756b38d
Compare
Base automatically changed from
ref/delete-code-review-event-pending
to
master
February 27, 2026 09:22
Drop the sentry_code_review_event table. This is the second step of the safe deletion process (MOVE_TO_PENDING was in the previous migration). The table will be recreated with an updated schema in a follow-up PR. Co-Authored-By: Claude <noreply@anthropic.com>
vaind
force-pushed
the
ref/delete-code-review-event
branch
from
756b38d to
37605c0
Compare
Contributor
|
This PR has a migration; here is the generated SQL for for --
-- Delete model CodeReviewEvent
--
DROP TABLE "sentry_code_review_event" CASCADE; |
armenzg
approved these changes
Feb 27, 2026
vaind
added a commit
that referenced
this pull request
Mar 4, 2026
…9424) Recreate the `CodeReviewEvent` table with reviewer feedback from PR #108531 applied: - `DefaultFieldsModel` base class for standard `date_added`/`date_updated` fields - `FlexibleForeignKey` for organization and repository (cascade deletion, referential integrity) - `RelocationScope.Global` to match `Repository`'s scope (required for org-scoped exports since Repository is Global) - `DateUpdatedComparator` for `date_added`/`date_updated` in backup comparators - Backup test coverage in `create_exhaustive_organization()` Migration is a clean auto-generated `CreateModel` — no manual edits. **This is PR 3 of 3:** 1. #109420 — `SafeDeleteModel` with `MOVE_TO_PENDING` (merged) 2. #109422 — `SafeDeleteModel` with `DELETE` (merged) 3. **This PR** — Recreate with updated schema --------- Co-authored-by: Claude <noreply@anthropic.com>
JonasBa
pushed a commit
that referenced
this pull request
Mar 5, 2026
…9424) Recreate the `CodeReviewEvent` table with reviewer feedback from PR #108531 applied: - `DefaultFieldsModel` base class for standard `date_added`/`date_updated` fields - `FlexibleForeignKey` for organization and repository (cascade deletion, referential integrity) - `RelocationScope.Global` to match `Repository`'s scope (required for org-scoped exports since Repository is Global) - `DateUpdatedComparator` for `date_added`/`date_updated` in backup comparators - Backup test coverage in `create_exhaustive_organization()` Migration is a clean auto-generated `CreateModel` — no manual edits. **This is PR 3 of 3:** 1. #109420 — `SafeDeleteModel` with `MOVE_TO_PENDING` (merged) 2. #109422 — `SafeDeleteModel` with `DELETE` (merged) 3. **This PR** — Recreate with updated schema --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the
sentry_code_review_eventtable. This is the second step of the safe deletion process.Stacked on #109420 (pending delete). Retarget to
masterafter PR 1 merges.This is PR 2 of 3:
SafeDeleteModelwithMOVE_TO_PENDING(removes model from Django state)SafeDeleteModelwithDELETE(drops the table)