fix(aci): Don't process deleted workflows in process_delayed_workflows #105784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Member
Author
|
We should probably handle the redis clean-up structurally rather than doing it at every exit point, but that's a different change. |
cathteng
approved these changes
Jan 7, 2026
Member
cathteng
left a comment
cathteng
left a comment
There was a problem hiding this comment.
TIL we have a WorkflowManager that automatically excludes workflows pending deletion / being deleted when querying 🤯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a workflow is being deleted, we should disregard any scheduled attempts to evaluate it.
It's still possible for it to be deleted while we're processing since we don't entirely do an up-front fetch, but this ensures a subsequent retry will not have the same issue.
Addresses ISWF-819.