feat(dynamic-grouping): Allow clicking top issue card to view more #105776
Conversation
takes you to the single card layout
github-actions
bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
| checked={filterByAssignedToMe} | ||
| onChange={e => { | ||
| setFilterByAssignedToMe(e.target.checked); | ||
| setCurrentIndex(0); | ||
| }} |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| </FooterActions> | ||
| </CardFooter> | ||
| </CardContainer> | ||
| </CardLink> |
There was a problem hiding this comment.
Nested interactive elements inside CardLink cause navigation conflicts
High Severity
The CardLink component wraps the entire card including interactive children: multiple Button components with click handlers, two DropdownMenu components, and a nested Link element. Clicking on any of these will bubble up to the parent CardLink and trigger navigation to the top-issues page, preventing users from using the buttons and dropdown menus. Additionally, the nested Link inside CardLink creates invalid HTML (anchor inside anchor) with undefined browser behavior. The interactive elements in FooterActions need event propagation stopped or a different card-click implementation.
| checked={filterByAssignedToMe} | ||
| onChange={e => { | ||
| setFilterByAssignedToMe(e.target.checked); | ||
| setCurrentIndex(0); |
There was a problem hiding this comment.
Filter changes don't update URL causing state desync
Medium Severity
When the "Assigned to me" checkbox is toggled, only local state is updated via setFilterByAssignedToMe, but the URL is not updated. If the currently selected cluster (from URL's cluster param) gets filtered out, currentIndex correctly falls back to 0, but the URL still contains the old cluster ID. This creates a desync where the displayed cluster differs from the URL. Refreshing the page would show unexpected content, and shared links would behave inconsistently. The previous implementation explicitly reset the index; the new URL-based approach needs to navigate to the new current cluster when the filter changes.
clicking on a card takes you to the single card view. fixes paginating single card view