-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(perforce): Add frontend support for Perforce integration #103172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit adds frontend support for Perforce version control integration: - New Perforce icon component and assets - Integration icon and plugin support - Updated repository project path config form to support Perforce - Type definitions for Perforce integration The frontend changes enable: - Visual representation of Perforce integration in the UI - Configuration UI for repository and code mappings - Integration with existing VCS provider infrastructure
static/app/views/settings/organizationIntegrations/repositoryProjectPathConfigForm.tsx
Outdated
Show resolved
Hide resolved
static/app/views/settings/organizationIntegrations/repositoryProjectPathConfigForm.tsx
Outdated
Show resolved
Hide resolved
|
What does this look like on the integrations page? Should we prevent people from seeing it and installing the integration via the feature flag? e.g. sentry/static/app/views/issueDetails/streamline/sidebar/seerNotices.tsx Lines 121 to 123 in b4e2249
|
|
@cathteng not sure what the code-snippet you pasted is for. With the flag I added in the backend PR (#103287) - if not toggled for an org the Integration is not shown in the Integrations page at all. requires_feature_flag is actually preventing it from being picked up by the frontend (same as visible flag). |
|
if you don't see it locally, then it's fine |
This commit adds frontend support for Perforce version control integration:
The frontend changes enable: