Skip to content

fix(core): Restore touch breadcrumbs on New Architecture from RN 0.88 - #7013

Merged
antonis merged 7 commits into
mainfrom
fix/touch-breadcrumbs-rn-088
Nov 11, 2026
Merged

antonis merged 7 commits into
mainfrom
fix/touch-breadcrumbs-rn-088

Conversation

@antonis

@antonis antonis commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

TouchEventBoundary now falls back to e.target.__internalInstanceHandle when the touch event has no _targetInst. _targetInst stays the first choice, so older React Native versions and the Old Architecture keep their existing path.

This restores touch breadcrumbs, rage tap detection and user interaction spans, which all returned early on the missing _targetInst. Label reading, text extraction and Sentry.Mask handling run on the same fiber as before.

💡 Motivation and Context

Fixes #7009

💚 How did you test it?

  • Tests / CI
  • Sample app on React Native 0.88.1
Platform SDK Touch breadcrumbs in the event Link to Sentry
iOS (iPhone 16 Pro simulator, iOS 18.1) Without the fix none 5cdcb13f
iOS (iPhone 16 Pro simulator, iOS 18.1) With the fix Touch event within element: Text 54a6673e
Android (Pixel 8 emulator) Without the fix none 18b493da
Android (Pixel 8 emulator) With the fix Touch event within element: Text 2aa58b09

📝 Checklist

  • I added tests to verify changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.
  • No breaking changes.

🔮 Next steps

antonis and others added 2 commits November 10, 2026 13:31
With EventTarget-based dispatching, touch events have no `_targetInst`,
so TouchEventBoundary silently recorded nothing. Fall back to the fiber
on the event target.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Semver Impact of This PR

⚪ None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


  • fix(core): Restore touch breadcrumbs on New Architecture from RN 0.88 by antonis and claude in #7013
  • fix(android): Mask prepared text layout views in replay and screenshots by antonis and claude in #7011
  • chore: Restore individual maintainers as default code owners by christophaigner with sentry-junior in #7017
  • feat(android): Add enableUserInteractionBreadcrumbs option by GersonRocha9 in #7016
  • fix(ios): Register replay mask classes when sample rates are 0 by alwx in #7008
  • feat(ios): Forward experimental enableWatchdogTerminationsV2 to sentry-cocoa by alwx in #7012
  • docs: Update Warden skills mentioned in the review skill by antonis and claude in #7004
  • ci: Skip CI for warden.toml-only changes by antonis and claude in #7005
  • build(deps): Bump joi to 17.13.9 to resolve ReDoS advisory by antonis and claude in #7003
  • chore(deps): bump getsentry/craft from 3.9.0 to 3.11.1 by dependabot in #7001
  • chore(deps): bump getsentry/craft/.github/workflows/changelog-preview.yml from 3.9.0 to 3.11.1 by dependabot in #6999
  • chore(deps): bump actions/setup-java from 6.1.0 to 6.2.0 by dependabot in #7002
  • chore(deps): bump ruby/setup-ruby from 1.336.0 to 1.338.0 by dependabot in #7000
  • chore(deps): bump the codeql-action group with 3 updates by dependabot in #6998
  • chore(warden): Remove find-bugs, already covered by code-review by dcramer with sentry-junior in #6997
  • chore(deps): update Sentry Android Gradle Plugin to v6.26.0 by github-actions in #6995
  • chore(warden): Enable incremental review by Jeffreyhung with sentry-junior in #6994
  • chore(deps): update Android SDK to v8.63.0 by github-actions in #6990

🤖 This preview updates automatically when you update the PR.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 2f7fe4e. Configure here.

@antonis antonis added the ready-to-merge Triggers the full CI test suite label Nov 10, 2026
antonis and others added 2 commits November 10, 2026 13:47
The existing tests hand-build events, so they cannot detect React Native
changing how the touched fiber is exposed. Run the boundary through the
real renderer and event dispatch, and warn in debug when no fiber is found.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@antonis
antonis marked this pull request as ready for review November 10, 2026 12:51
@antonis
antonis requested review from a team and lucas-zimerman as code owners November 10, 2026 12:51
@antonis
antonis requested review from alwx and buenaflor and removed request for a team November 10, 2026 12:51
@sentry

sentry Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
Sentry RN io.sentry.reactnative.sample 8.34.0 (114) Release

⚙️ sentry-react-native Build Distribution Settings

@antonis antonis removed the ready-to-merge Triggers the full CI test suite label Nov 10, 2026
@antonis antonis added the ready-to-merge Triggers the full CI test suite label Nov 11, 2026

@lucas-zimerman lucas-zimerman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@antonis antonis removed the ready-to-merge Triggers the full CI test suite label Nov 11, 2026
@antonis
antonis enabled auto-merge (squash) November 11, 2026 12:32
@github-actions

Copy link
Copy Markdown
Contributor
Fails
🚫 Pull request is not ready for merge, please add the "ready-to-merge" label to the pull request

Generated by 🚫 dangerJS against fdb883a

@antonis
antonis merged commit cc13e90 into main Nov 11, 2026
54 of 71 checks passed
@antonis
antonis deleted the fix/touch-breadcrumbs-rn-088 branch November 11, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Touch breadcrumbs lost on New Architecture from RN 0.88 (_targetInst missing)

2 participants