Skip to content

Ref(CI): Unify stub update with android update#5807

Merged
lucas-zimerman merged 2 commits intomainfrom
lz/update-stubs
Mar 13, 2026
Merged

Ref(CI): Unify stub update with android update#5807
lucas-zimerman merged 2 commits intomainfrom
lz/update-stubs

Conversation

@lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Mar 12, 2026

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

When updating the Android SDK, it should also update the stub dependency, this PR merge the stub/android update into a single PR.

💡 Motivation and Context

No outdated stub after updating Android SDK.

💚 How did you test it?

Claude

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

Close #5230

@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2026

Semver Impact of This PR

None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


  • Ref(CI): Unify stub update with android update by lucas-zimerman in #5807
  • feat(core): Generate sentry.options.json from Expo plugin config by antonis in #5804
  • Pass screenshotStrategy option from mobileReplayIntegration to the Android SDK by alwx in #5808
  • fix(core): Exclude server-only AI/MCP modules from native bundles by antonis in #5802
  • chore(deps): update Cocoa SDK to v9.7.0 by github-actions in #5805
  • chore(deps): update CLI to v3.3.3 by github-actions in #5806
  • Automatically capture a warning event when Expo Updates performs an emergency launch by alwx in #5794
  • fix(core): Improve native init log message clarity by antonis in #5801
  • feat(core): Add environment option to Expo config plugin by antonis in #5796
  • chore(deps): update CLI to v3.3.2 by github-actions in #5799
  • chore(deps): update Maestro to v2.3.0 by github-actions in #5790
  • chore(deps): update JavaScript SDK to v10.43.0 by github-actions in #5791
  • chore(deps): update CLI to v3.3.1 by github-actions in #5793
  • fix(core): Defer initial navigation span creation until navigation container is registered by antonis in #5789
  • Ref(Sample): Add existing bundled playgroundscreen into sample app by lucas-zimerman in #5778
  • Auto tracing for expo-image and expo-asset by alwx in #5718
  • Expo Updates: add tags with Expo Updates context vars to make them searchable/filterable by alwx in #5788
  • chore(deps): bump actions/setup-node from 6.2.0 to 6.3.0 by dependabot in #5784
  • chore(deps): bump github/codeql-action from 4.32.4 to 4.32.6 by dependabot in #5781
  • chore(deps): bump getsentry/craft/.github/workflows/changelog-preview.yml from 2.23.1 to 2.23.2 by dependabot in #5782
  • chore(deps): bump getsentry/craft from 2.21.7 to 2.23.2 by dependabot in #5783
  • chore(deps): bump tar to ^7.5.10 by antonis in #5777

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2026

Fails
🚫 Pull request is not ready for merge, please add the "ready-to-merge" label to the pull request

Generated by 🚫 dangerJS against b221a5f

@lucas-zimerman lucas-zimerman marked this pull request as ready for review March 12, 2026 10:47
@lucas-zimerman
Copy link
Collaborator Author

The changed code Isn't validated by any CI, so that's why I am skipping the ready-to-merge flag.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

cd ..
yarn build:replay-stubs || true
;;
*)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The yarn build:replay-stubs || true command will silently fail in CI due to missing dependencies, causing a stale replay-stubs.jar to be committed.
Severity: HIGH

Suggested Fix

Remove || true from the command to ensure the script fails loudly if the build fails. Additionally, ensure the CI environment has the necessary dependencies (Node.js, yarn, Java/Gradle) installed to execute the build command successfully.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: scripts/update-android-stubs.sh#L28

Potential issue: The script `update-android-stubs.sh` uses `yarn build:replay-stubs ||
true` to rebuild a JAR file. The CI environment where this script runs likely lacks the
necessary dependencies (Node.js, yarn, Gradle). The `|| true` will suppress the error
when the build command fails, causing the script to appear successful. This results in a
stale `replay-stubs.jar` artifact being committed to the repository, which will be out
of sync with the updated Android SDK version. This discrepancy can lead to build
failures or runtime issues for users of the SDK.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, but it's better to silently fail the stub code than silently fail the entire CI bump.
We can always check the Bump Action from stub when a PR updates Android but doesn't update the stub.

Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
Thank you for fixing this @lucas-zimerman 🙇
Before merging let's close #5760 and #5765 and verify that the Android PR is properly recreated when the update-deps runs on main.

@lucas-zimerman lucas-zimerman merged commit 66fcf50 into main Mar 13, 2026
52 of 57 checks passed
@lucas-zimerman lucas-zimerman deleted the lz/update-stubs branch March 13, 2026 11:47
@antonis
Copy link
Contributor

antonis commented Mar 13, 2026

let's close #5760 and #5765 and verify that the Android PR is properly recreated

@lucas-zimerman The Android bump PR was created successfully #5810 but I think the jar was not created. I think this is due to the yarn build:replay-stubs failing silently due to the yarn version mismatch

error This project's package.json defines "packageManager": "yarn@3.6.4". However the current global version of Yarn is 1.22.22.

Note that I've rerun the job after also deleting the branches

@lucas-zimerman
Copy link
Collaborator Author

let's close #5760 and #5765 and verify that the Android PR is properly recreated

@lucas-zimerman The Android bump PR was created successfully #5810 but I think the jar was not created. I think this is due to the yarn build:replay-stubs failing silently due to the yarn version mismatch

error This project's package.json defines "packageManager": "yarn@3.6.4". However the current global version of Yarn is 1.22.22.

Note that I've rerun the job after also deleting the branches

I think so too, I will remove the yarn dependency and replace it by the gradlew build command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automate Android Session Replay Stub .jar creation

2 participants